Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ONNX] Default to dynamo export#159646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
justinchuby wants to merge7 commits intomainfromjustinchuby/dynamo-true
Closed

Conversation

@justinchuby
Copy link
Collaborator

@justinchubyjustinchuby commentedAug 1, 2025•
edited
Loading

Set dynamo=True and enable fallback.

  1. Implemented the compatible behavior where BytesIO objects asf is accepted
  2. Update tests to explicitly set dynamo=False

#151693

cc@titaiwangms

@pytorch-bot
Copy link

pytorch-botbot commentedAug 1, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/159646

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit5283603 with merge baseb7e207c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-botpytorch-botbot added the release notes: onnxtorch.onnx related changes that should show up in the release notes labelAug 1, 2025
@justinchubyjustinchuby added the keep-goingDon't stop on first failure, keep running tests until the end labelAug 1, 2025
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchubyjustinchuby added module: onnxRelated to torch.onnx module: bc-breakingRelated to a BC-breaking change and removed module: bc-breakingRelated to a BC-breaking change labelsAug 16, 2025
@pytorch-botpytorch-botbot added the topic: bc breakingtopic category labelAug 16, 2025
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Copy link
CollaboratorAuthor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelAug 16, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchubyjustinchuby deleted the justinchuby/dynamo-true branchAugust 16, 2025 05:41
@facebook-github-bot
Copy link
Contributor

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current statushere.
Questions? Feedback? Please reach out to thePyTorch DevX Team

pytorchmergebot added a commit that referenced this pull requestAug 18, 2025
This reverts commit11b6ceb.Reverted#159646 on behalf ofhttps://github.com/facebook-github-bot due to Diff reverted internally ([comment](#159646 (comment)))
@pytorchmergebot
Copy link
Collaborator

@justinchuby your PR has been successfully reverted.

@pytorchmergebotpytorchmergebot added Reverted ci-no-tdDo not run TD on this PR labelsAug 18, 2025
@titaiwangms
Copy link
Collaborator

cc@tugsbayasgalan@pianpwk@angelayi (Meta internal breaks)

@angelayi
Copy link
Contributor

angelayi commentedAug 18, 2025•
edited
Loading

@titaiwangms I mentioned this in the slack channel but it seems like dynamo=True creates a dependency on onnxscript, which is not imported in our internal codebase, causing many failures. To fix this, we'll first patch all the internal code to call dynamo=False and then land this PR.

titaiwangms reacted with thumbs up emoji

@justinchubyjustinchuby restored the justinchuby/dynamo-true branchAugust 21, 2025 15:36
@justinchuby
Copy link
CollaboratorAuthor

Were you able to make the internal changes?

can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull requestAug 22, 2025
Set dynamo=True and enable fallback.1. Implemented the compatible behavior where BytesIO objects as `f` is accepted2. Update tests to explicitly set dynamo=Falsepytorch#151693Pull Requestresolved:pytorch#159646Approved by:https://github.com/titaiwangms
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull requestAug 22, 2025
@justinchuby
Copy link
CollaboratorAuthor

@angelayi checking again if you made any progress? Thanks!

@angelayi
Copy link
Contributor

Sorry I set up the codemod but it hasn't modified all the files yet! will update this thread once it's finished!

justinchuby reacted with heart emoji

@justinchubyjustinchuby modified the milestones:2.10.0,2.9.0Aug 31, 2025
@titaiwangmstitaiwangms linked an issueSep 2, 2025 that may beclosed by this pull request
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Copy link
CollaboratorAuthor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull requestSep 17, 2025
Set dynamo=True and enable fallback.1. Implemented the compatible behavior where BytesIO objects as `f` is accepted2. Update tests to explicitly set dynamo=Falsepytorch#151693Pull Requestresolved:pytorch#159646Approved by:https://github.com/titaiwangms
markc-614 pushed a commit to markc-614/pytorch that referenced this pull requestSep 17, 2025
markc-614 pushed a commit to markc-614/pytorch that referenced this pull requestSep 17, 2025
Set dynamo=True and enable fallback.1. Implemented the compatible behavior where BytesIO objects as `f` is accepted2. Update tests to explicitly set dynamo=Falsepytorch#151693Pull Requestresolved:pytorch#159646Approved by:https://github.com/titaiwangms
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull requestSep 22, 2025
Set dynamo=True and enable fallback.1. Implemented the compatible behavior where BytesIO objects as `f` is accepted2. Update tests to explicitly set dynamo=Falsepytorch#151693Pull Requestresolved:pytorch#159646Approved by:https://github.com/titaiwangms
@github-actionsgithub-actionsbot deleted the justinchuby/dynamo-true branchOctober 3, 2025 02:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@titaiwangmstitaiwangmstitaiwangms approved these changes

@xaduprexadupreAwaiting requested review from xadupre

Assignees

No one assigned

Labels

ci-no-tdDo not run TD on this PRciflow/trunkTrigger trunk jobs on your pull requestkeep-goingDon't stop on first failure, keep running tests until the endMergedmodule: onnxRelated to torch.onnxopen sourcerelease notes: onnxtorch.onnx related changes that should show up in the release notesRevertedtopic: bc breakingtopic category

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

[ONNX] Flipdynamo default to True in torch.onnx.export

7 participants

@justinchuby@pytorchmergebot@facebook-github-bot@titaiwangms@angelayi@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp