Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MPS] Reimplementtri[ul] as Metal shaders#158867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
malfet merged 1 commit intorelease/2.8fromcherry-pick-157179-by-pytorch_bot_bot_
Jul 22, 2025

Conversation

@pytorchbot
Copy link
Collaborator

@pytorchbotpytorchbot commentedJul 22, 2025•
edited by malfet
Loading

And add in-place flavor, as it is currently broken for non-contiguous tensors.

And add in-place flavor, as it is currently broken for non-contig tensorsPull Requestresolved:#157179Approved by:https://github.com/dcci(cherry picked from commita1e4f1f)
@pytorch-botpytorch-botbot added ciflow/mpsRun MPS tests (subset of trunk) release notes: mpsRelease notes category labelsJul 22, 2025
@pytorch-bot
Copy link

pytorch-botbot commentedJul 22, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/158867

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 52 Pending

As of commit342aa8f with merge base3a7ff82 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@atalmanatalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@malfetmalfet merged commit5534685 intorelease/2.8Jul 22, 2025
60 of 106 checks passed
tvukovic-amd pushed a commit to ROCm/pytorch that referenced this pull requestAug 20, 2025
[MPS] Reimplement `tri[ul]` as Metal shaders (pytorch#157179)And add in-place flavor, as it is currently broken for non-contig tensorsPull Requestresolved:pytorch#157179Approved by:https://github.com/dcci(cherry picked from commita1e4f1f)Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
@github-actionsgithub-actionsbot deleted the cherry-pick-157179-by-pytorch_bot_bot_ branchAugust 22, 2025 02:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@malfetmalfetmalfet approved these changes

@atalmanatalmanatalman approved these changes

@kulinsethkulinsethAwaiting requested review from kulinsethkulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mpsRun MPS tests (subset of trunk)open sourcerelease notes: mpsRelease notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pytorchbot@malfet@atalman
[8]ページ先頭
©2009-2025 Movatter.jp