Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ONNX] Update default opset to 18#156023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
justinchuby wants to merge10 commits intomainfromjustinchu/default-18
Closed

Conversation

@justinchuby
Copy link
Collaborator

@justinchubyjustinchuby commentedJun 15, 2025•
edited
Loading

Update default opset for the torchscript exporter to 18 to match the dynamo exporter, because support was actaully added and tested in#118828. In the next version we should plan to update to opset 21 or higher. This change also removes the hard limit on the torchscript exporter for more flexibility.

@pytorch-bot
Copy link

pytorch-botbot commentedJun 15, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/156023

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit423f1ba with merge base655b3b1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-botpytorch-botbot added the release notes: onnxtorch.onnx related changes that should show up in the release notes labelJun 15, 2025
@justinchubyjustinchuby added module: onnxRelated to torch.onnx topic: bc breakingtopic category labelsJun 15, 2025
@justinchubyjustinchuby added this to the2.8.0 milestoneJun 15, 2025

conststaticintkInvalidOpsetVersion = -1;
conststaticintkMainOpsetVersion =20;
conststaticintkMainOpsetVersion =23;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ni: why isn't this constexpr?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done

@justinchubyjustinchuby added the ciflow/trunkTrigger trunk jobs on your pull request labelJun 16, 2025
@justinchuby
Copy link
CollaboratorAuthor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchubyjustinchuby deleted the justinchu/default-18 branchJune 16, 2025 12:55
@justinchuby
Copy link
CollaboratorAuthor

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@titaiwangmstitaiwangmstitaiwangms left review comments

@Skylion007Skylion007Skylion007 approved these changes

@shubhambhokare1shubhambhokare1Awaiting requested review from shubhambhokare1

@wschinwschinAwaiting requested review from wschin

@xaduprexadupreAwaiting requested review from xadupre

Assignees

No one assigned

Labels

ciflow/trunkTrigger trunk jobs on your pull requestMergedmodule: onnxRelated to torch.onnxopen sourcerelease notes: onnxtorch.onnx related changes that should show up in the release notestopic: bc breakingtopic category

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@justinchuby@pytorchmergebot@Skylion007@titaiwangms@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp