NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

[BE] Fix minifier when one has multiple Python runtimes#155918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

malfet wants to merge1 commit intomainfrommalfet-patch-20

Closed

[BE] Fix minifier when one has multiple Python runtimes#155918

malfet wants to merge1 commit intomainfrommalfet-patch-20

Conversation

Copy link

Contributor

malfet commentedJun 13, 2025•
edited by pytorch-botbot
Loading

By usingsys.executable instead of"python"

Otherwise, it fails on Ubuntu withpython not found error

cc@voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

[BE] Fix minifier when one has multiple Python runtimes

773429a

By using `sys.executable` instead of `"python"`Otherwise, it fails on Ubuntu with `python not found` error

malfet requested a review fromezyang

June 13, 2025 16:35

Copy link

pytorch-botbot commentedJun 13, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/155918

📄 PreviewPython docs built from this PR
📄 PreviewC++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit thebot commands wiki or ouroffice hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 53 Pending, 3 Unrelated Failures

As of commit773429a with merge base338a8c7 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

inductor / unit-test / cuda12.8-py3.13-gcc9-sm86 / test (inductor, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-botbot added ciflow/inductor module: dynamo labels

Jun 13, 2025

seemethere approved these changes

Jun 13, 2025

View reviewed changes

malfet added topic: bug fixes

topic category

release notes: inductor labels

Jun 13, 2025

Copy link

ContributorAuthor

malfet commentedJun 13, 2025

@pytorchbot merge

pytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request label

Jun 13, 2025

ZainRizvi approved these changes

Jun 13, 2025

View reviewed changes

pytorchmergebot added the merging label

Jun 13, 2025

Copy link

Collaborator

pytorchmergebot commentedJun 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

zou3519 approved these changes

Jun 13, 2025

View reviewed changes

Copy link

ContributorAuthor

malfet commentedJun 13, 2025

@pytorchbot merge -f "¯_(ツ)_/¯"

Copy link

pytorch-botbot commentedJun 13, 2025

You need to provide a reason for using force merge, in the format@pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

Bypass checks due to unrelated upstream failures from ...
This is a minor fix to ..., which shouldn't break anything
This is pre-tested in a previous CI run
Bypass flaky ... check

Copy link

ContributorAuthor

malfet commentedJun 13, 2025

@pytorchbot merge -f "¯\(ツ)/¯ ¯\(ツ)/¯ ¯\(ツ)/¯ "

Copy link

Collaborator

pytorchmergebot commentedJun 13, 2025

The mergejob was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information seepytorch-bot wiki.

Copy link

Collaborator

pytorchmergebot commentedJun 13, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag,bypassing any CI checks (ETA: 1-5 minutes). Please use-f as last resort and instead consider-i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in36bf81e

Jun 13, 2025

pytorchmergebot added Merged and removed merging labels

Jun 13, 2025

github-actionsbot deleted the malfet-patch-20 branch

July 14, 2025 02:23

lingebeng added a commit to lingebeng/pytorch that referenced this pull request

Oct 16, 2025

[Fix] Use sys.executable instead of hardcoded "python" command

f2b06ed

Fix hardcoded python executable path with sys.executableReplace hardcoded "python" string with sys.executable to ensurecorrect Python interpreter is used. This fixes failures on systemswith multiple Python runtimes or where "python" is not in PATH.Similar topytorch#155918

lingebeng mentioned this pull request

Oct 16, 2025

[Fix] Use sys.executable instead of hardcoded "python" command when one has multiple Python runtimes#165632

Closed

lingebeng added a commit to lingebeng/pytorch that referenced this pull request

Oct 16, 2025

[Fix] fix hardcoded python executable path with sys.executable

e3b0435

Fix hardcoded python executable path with sys.executable  Replace hardcoded "python" string with sys.executable to ensure  correct Python interpreter is used. This fixes failures on systems  with multiple Python runtimes or where "python" is not in PATH.  Similar topytorch#155918

lingebeng added a commit to lingebeng/pytorch that referenced this pull request

Oct 16, 2025

[Fix] Use sys.executable instead of hardcoded python

e65ac8f

Replace hardcoded "python" string with sys.executable to ensurecorrect Python interpreter is used. This fixes failures on systemswith multiple Python runtimes or where "python" is not in PATH.Similar topytorch#155918

lingebeng mentioned this pull request

Oct 16, 2025

[Fix] Use sys.executable instead of hardcoded python#165633

Closed

pytorchmergebot pushed a commit that referenced this pull request

Oct 16, 2025

[Fix] Use sys.executable instead of hardcoded python (#165633)

37f3ba2

Replace hardcoded "python" string with sys.executable to ensure correct Python interpreter is used. This fixes failures on systems with multiple Python runtimes or where "python" is not in PATH.Similar to#155918Fixes #ISSUE_NUMBERPull Requestresolved:#165633Approved by:https://github.com/Skylion007

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request

Oct 21, 2025

[Fix] Use sys.executable instead of hardcoded python (pytorch#165633)

9625274

Replace hardcoded "python" string with sys.executable to ensure correct Python interpreter is used. This fixes failures on systems with multiple Python runtimes or where "python" is not in PATH.Similar topytorch#155918Fixes #ISSUE_NUMBERPull Requestresolved:pytorch#165633Approved by:https://github.com/Skylion007

zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request

Oct 22, 2025

[Fix] Use sys.executable instead of hardcoded python (pytorch#165633)

3b568bd

Replace hardcoded "python" string with sys.executable to ensure correct Python interpreter is used. This fixes failures on systems with multiple Python runtimes or where "python" is not in PATH.Similar topytorch#155918Fixes #ISSUE_NUMBERPull Requestresolved:pytorch#165633Approved by:https://github.com/Skylion007