Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[MPS] Implement erfc#155382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
malfet wants to merge3 commits intogh/malfet/384/basefromgh/malfet/384/head
Closed

Conversation

@malfet
Copy link
Contributor

@malfetmalfet commentedJun 7, 2025
edited
Loading

[ghstack-poisoned]
@malfetmalfet requested a review fromkulinseth as acode ownerJune 7, 2025 00:21
@pytorch-bot
Copy link

pytorch-botbot commentedJun 7, 2025
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/155382

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 61 Pending

As of commit8d16b87 with merge base7e4c097 (image):
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-botpytorch-botbot added ciflow/mpsRun MPS tests (subset of trunk) release notes: mpsRelease notes category labelsJun 7, 2025
@malfetmalfet added the topic: improvementstopic category labelJun 7, 2025
@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. Seehttps://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

[ghstack-poisoned]
[ghstack-poisoned]
@malfet
Copy link
ContributorAuthor

@pytorchbot merge -f "Lint + MPS are green"

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag,bypassing any CI checks (ETA: 1-5 minutes). Please use-f as last resort and instead consider-i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull requestJun 8, 2025
Vibe-coded with Codex, after collecting a backtrace, seehttps://chatgpt.com/s/cd_68438be8a1248191adbfa0a5f000e60bEven though, check for empty tensor list exists in `at::cat` crash might happens while resolving named dimension to position, by calling `dimname_to_position(tensors[0], dim)`, see backtrace below```(lldb) upframe#1: 0x00000001101146dc libtorch_cpu.dylib`at::TensorBase::has_names(this=0x0000000000000000) const at TensorBase.h:559:10   556   bool has_names() const {   557     // If a user is using unnamed tensors, then we can short-circuit right here.   558     // Otherwise, impl::has_names attempts to retrieve names.-> 559     if (!impl_->has_named_tensor_meta()) {   560       return false;   561     }   562     return impl::has_names(unsafeGetTensorImpl());(lldb) upframe#2: 0x00000001101144c4 libtorch_cpu.dylib`at::dimname_to_position(tensor=0x0000000000000000, dim=Dimname @ 0x000000016fdfe348) at NamedTensorUtils.cpp:23:3   20  int64_t dimname_to_position(const Tensor& tensor, Dimname dim) {   21    TORCH_CHECK(dim.type() != NameType::WILDCARD,   22        "Please look up dimensions by name, got: name = None.");-> 23    TORCH_CHECK(tensor.has_names(),   24        "Name ", dim, " not found in ", toDimnameRepr(tensor), ".");   25    const auto names = tensor.names();   26```TODOs: - May be move test from `test_tensor_creation.py` to OpInfo (not sure which one is more readable) - Replace  `TORCH_CHECK` with `TORCH_CHECK_VALUE` and adjust unit testsFixes#155306Pull Requestresolved:#155383Approved by:https://github.com/cyyever,https://github.com/ezyangghstack dependencies:#155382
@github-actionsgithub-actionsbot deleted the gh/malfet/384/head branchJuly 9, 2025 02:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dccidccidcci approved these changes

@manuelcandalesmanuelcandalesmanuelcandales approved these changes

@kulinsethkulinsethAwaiting requested review from kulinseth

@Skylion007Skylion007Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

ciflow/inductorciflow/mpsRun MPS tests (subset of trunk)Mergedmodule: inductorrelease notes: mpsRelease notes categorytopic: improvementstopic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet@pytorchmergebot@dcci@manuelcandales

[8]ページ先頭

©2009-2025 Movatter.jp