Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MPS] Fix unary/binary ops for 2**32+ elem tensors#155183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
malfet wants to merge4 commits intogh/malfet/379/basefromgh/malfet/379/head

Conversation

@malfet
Copy link
Contributor

@malfetmalfet commentedJun 5, 2025•
edited
Loading

Stack fromghstack (oldest at bottom):

By usingTensorIterator::with_32bit_indexing() primitive

Addbind_tensors helper function that correctly sets up MPS tensors originating from TensorIterator

TODO: Add comments to bind_tensors as well asunit test, based on

python  -c "import torch;print((torch.rand(1, 1024, 1024, dtype=torch.bfloat16, device='mps') + torch.rand(5000, 1, 1, dtype=torch.bfloat16, device='mps')).sin())"

Fixes#154828

[ghstack-poisoned]
@malfetmalfet requested a review fromkulinseth as acode ownerJune 5, 2025 01:21
@pytorch-bot
Copy link

pytorch-botbot commentedJun 5, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/155183

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Cancelled Jobs, 2 Pending

As of commit80f5d62 with merge base31d12b3 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-botpytorch-botbot added ciflow/mpsRun MPS tests (subset of trunk) release notes: mpsRelease notes category labelsJun 5, 2025
@malfetmalfet requested review fromSkylion007 anddcciJune 5, 2025 01:21
@malfetmalfet added the topic: bug fixestopic category labelJun 5, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
malfet added a commit that referenced this pull requestJun 5, 2025
By using `TensorIterator..with_32bit_indexing()` primitiveAdd `bind_tensors` helper function that correctly sets up MPS tensors originating from TensorIteratorTODO: Add unit test, based on```python  -c "import torch;print((torch.rand(1, 1024, 1024, dtype=torch.bfloat16, device='mps') + torch.rand(5000, 1, 1, dtype=torch.bfloat16, device='mps')).sin())"```ghstack-source-id:dd9ed1bPull Requestresolved:#155183
@malfet
Copy link
ContributorAuthor

@pytorchbot merge -f "Lint + MPS are green"

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag,bypassing any CI checks (ETA: 1-5 minutes). Please use-f as last resort and instead consider-i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actionsgithub-actionsbot deleted the gh/malfet/379/head branchJuly 6, 2025 02:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Skylion007Skylion007Skylion007 approved these changes

@dccidccidcci approved these changes

@cyyevercyyevercyyever approved these changes

@kulinsethkulinsethAwaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/mpsRun MPS tests (subset of trunk)Mergedrelease notes: mpsRelease notes categorytopic: bug fixestopic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malfet@pytorchmergebot@Skylion007@dcci@cyyever
[8]ページ先頭
©2009-2025 Movatter.jp