- Notifications
You must be signed in to change notification settings - Fork26.3k
[MPS][BE] Extend torch.special. to integer dtypes#155002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
pytorch-botbot commentedJun 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🔗 Helpful Links🧪 See artifacts and rendered test results athud.pytorch.org/pr/155002
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 20 PendingAs of commit7c32ff8 with merge base0fab322 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007 approved these changesJun 3, 2025
dcci approved these changesJun 3, 2025
ContributorAuthor
malfet commentedJun 3, 2025
@pytorchbot merge -f "Lint + MPS are green" |
Collaborator
pytorchmergebot commentedJun 3, 2025
Merge startedYour change will be merged immediately since you used the force (-f) flag,bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in thewiki. Questions? Feedback? Please reach out to thePyTorch DevX Team |
pytorchmergebot pushed a commit to Eliasj42/pytorch that referenced this pull requestJun 3, 2025
By changing the functor to looks as follows```metalstruct xlog1py_functor { template <typename T, enable_if_t<is_floating_point_v<T>, bool> = true> inline T operator()(const T a, const T b) { return static_cast<T>(c10::metal::xlog1py(a, b)); } template <typename T, enable_if_t<is_integral_v<T>, bool> = true> inline float operator()(const T a, const T b) { return c10::metal::xlog1py(float(a), float(b)); }};```Repeat the same for `zeta`, `chebyshev_polynomial_[tuvw]_functor` and `hermite_polynomial_h[e]_functor`Pull Requestresolved:pytorch#155002Approved by:https://github.com/Skylion007,https://github.com/dccighstack dependencies:pytorch#154936pytorchmergebot pushed a commit that referenced this pull requestJun 4, 2025
That creates _kernel_mps function that takes iterator and calls stub foritPull Requestresolved:#155081Approved by:https://github.com/dccighstack dependencies:#154936,#155002
pytorchmergebot pushed a commit that referenced this pull requestJun 4, 2025
Fixes#154895Pull Requestresolved:#155080Approved by:https://github.com/dcci,https://github.com/cyyeverghstack dependencies:#154936,#155002,#155081
iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull requestJun 4, 2025
By changing the functor to looks as follows```metalstruct xlog1py_functor { template <typename T, enable_if_t<is_floating_point_v<T>, bool> = true> inline T operator()(const T a, const T b) { return static_cast<T>(c10::metal::xlog1py(a, b)); } template <typename T, enable_if_t<is_integral_v<T>, bool> = true> inline float operator()(const T a, const T b) { return c10::metal::xlog1py(float(a), float(b)); }};```Repeat the same for `zeta`, `chebyshev_polynomial_[tuvw]_functor` and `hermite_polynomial_h[e]_functor`Pull Requestresolved:pytorch#155002Approved by:https://github.com/Skylion007,https://github.com/dccighstack dependencies:pytorch#154936iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull requestJun 4, 2025
That creates _kernel_mps function that takes iterator and calls stub foritPull Requestresolved:pytorch#155081Approved by:https://github.com/dccighstack dependencies:pytorch#154936,pytorch#155002
iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull requestJun 4, 2025
Fixespytorch#154895Pull Requestresolved:pytorch#155080Approved by:https://github.com/dcci,https://github.com/cyyeverghstack dependencies:pytorch#154936,pytorch#155002,pytorch#155081
angelayi pushed a commit to angelayi/pytorch that referenced this pull requestJun 5, 2025
By changing the functor to looks as follows```metalstruct xlog1py_functor { template <typename T, enable_if_t<is_floating_point_v<T>, bool> = true> inline T operator()(const T a, const T b) { return static_cast<T>(c10::metal::xlog1py(a, b)); } template <typename T, enable_if_t<is_integral_v<T>, bool> = true> inline float operator()(const T a, const T b) { return c10::metal::xlog1py(float(a), float(b)); }};```Repeat the same for `zeta`, `chebyshev_polynomial_[tuvw]_functor` and `hermite_polynomial_h[e]_functor`Pull Requestresolved:pytorch#155002Approved by:https://github.com/Skylion007,https://github.com/dccighstack dependencies:pytorch#154936angelayi pushed a commit to angelayi/pytorch that referenced this pull requestJun 5, 2025
That creates _kernel_mps function that takes iterator and calls stub foritPull Requestresolved:pytorch#155081Approved by:https://github.com/dccighstack dependencies:pytorch#154936,pytorch#155002
angelayi pushed a commit to angelayi/pytorch that referenced this pull requestJun 5, 2025
Fixespytorch#154895Pull Requestresolved:pytorch#155080Approved by:https://github.com/dcci,https://github.com/cyyeverghstack dependencies:pytorch#154936,pytorch#155002,pytorch#155081
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
better-engineeringRelatively self-contained tasks for better engineering contributors ciflow/mpsRun MPS tests (subset of trunk) Mergedrelease notes: mpsRelease notes category topic: improvementstopic category
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Stack fromghstack (oldest at bottom):
By changing the functor to looks as follows
Repeat the same for
zeta,chebyshev_polynomial_[tuvw]_functorandhermite_polynomial_h[e]_functor