NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

[c10d] Enhance`get_process_group_ranks()` to accept`group=None`#154902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

tsunghsienlee wants to merge1 commit intopytorch:mainfromtsunghsienlee:export-D75817800

Closed

[c10d] Enhance`get_process_group_ranks()` to accept`group=None`#154902

tsunghsienlee wants to merge1 commit intopytorch:mainfromtsunghsienlee:export-D75817800

Conversation

Copy link

Contributor

tsunghsienlee commentedJun 2, 2025•
edited by pytorch-botbot
Loading

Summary: This diff enhances theget_process_group_ranks() function to acceptgroup=None as an optional argument. This allows the function to return all ranks associated with the default process group if no group is specified.

Test Plan:
contbuild & OSS CI

Rollback Plan:

Differential Revision: D75817800

cc@H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

Copy link

pytorch-botbot commentedJun 2, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI.@tsunghsienlee, please do step 2 ofinternal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

pytorch-botbot added oncall: distributed

Add this issue/PR to distributed oncall triage queue

release notes: distributed (c10d)release notes category labels

Jun 2, 2025

Copy link

pytorch-botbot commentedJun 2, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/154902

📄 PreviewPython docs built from this PR
📄 PreviewC++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit thebot commands wiki or ouroffice hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit383fa90 with merge based3d64c6 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / win-vs2022-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral) (gh) (similar failure)
'Test'

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-jammy-cuda12.6-py3.10-gcc11-sm89 / test (default, 2, 5, linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (trunk failure)
test_expanded_weights.py::TestExpandedWeightModuleCUDA::test_module_nn_GRU_eval_mode_cuda_float32
pull / linux-jammy-py3-clang12-executorch / build (gh) (trunk failure)
Final attempt failed. Child_process exited with error code 1

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / unstable-linux-jammy-cuda12.6-py3.10-gcc11-sm89-xfail / build (gh)
ninja: build stopped: subcommand failed

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

Contributor

facebook-github-bot commentedJun 2, 2025

This pull request wasexported from Phabricator. Differential Revision:D75817800

facebook-github-bot added the fb-exported label

Jun 2, 2025

tsunghsienlee force-pushed theexport-D75817800 branch fromd08b894 to8e34f49Compare

June 2, 2025 21:06

Copy link

Contributor

facebook-github-bot commentedJun 2, 2025

This pull request wasexported from Phabricator. Differential Revision:D75817800

Copy link

ContributorAuthor

tsunghsienlee commentedJun 2, 2025

@pytorchbot label "suppress-api-compatibility-check"

pytorch-botbot added the suppress-api-compatibility-checkSuppresses the failures of API backward-compatibility linter (Lint/bc_linter) label

Jun 2, 2025

tsunghsienlee force-pushed theexport-D75817800 branch from8e34f49 to0eb13d5Compare

June 2, 2025 21:12

Copy link

Contributor

facebook-github-bot commentedJun 2, 2025

This pull request wasexported from Phabricator. Differential Revision:D75817800

tsunghsienlee force-pushed theexport-D75817800 branch from0eb13d5 to66ba7c9Compare

June 3, 2025 04:56

Copy link

Contributor

facebook-github-bot commentedJun 3, 2025

This pull request wasexported from Phabricator. Differential Revision:D75817800

tsunghsienlee force-pushed theexport-D75817800 branch from66ba7c9 to62c8cbdCompare

June 3, 2025 18:07

Copy link

Contributor

facebook-github-bot commentedJun 3, 2025

This pull request wasexported from Phabricator. Differential Revision:D75817800

tsunghsienlee force-pushed theexport-D75817800 branch from62c8cbd to36479bdCompare

June 4, 2025 01:06

Copy link

Contributor

facebook-github-bot commentedJun 4, 2025

This pull request wasexported from Phabricator. Differential Revision:D75817800

[c10d] Enhanceget_process_group_ranks()to acceptgroup=None(py…

383fa90

…torch#154902)Summary:This diff enhances the `get_process_group_ranks()` function to accept `group=None` as an optional argument. This allows the function to return all ranks associated with the default process group if no group is specified.Test Plan:contbuild & OSS CIRollback Plan:Differential Revision: D75817800

tsunghsienlee force-pushed theexport-D75817800 branch from36479bd to383fa90Compare

June 6, 2025 05:41

Copy link

Contributor