Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Preserve Enum types during torch.export serialization and deserialization#154821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
narekmalk wants to merge5 commits intopytorch:mainfromnarekmalk:154674_issue_fix

Conversation

@narekmalk
Copy link
Contributor

Fixes#154674

Addresses an issue wheretorch.export does not correctly preserve PythonEnum types during the save/load round-trip. Previously, Enum inputs were serialized by value only, causing their type to be lost after deserialization.

@pytorch-bot
Copy link

pytorch-botbot commentedJun 1, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/154821

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit6162f8d with merge basef6e18bc (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@narekmalk
Copy link
ContributorAuthor

@pytorchbot label "release notes: export"

pytorch-bot[bot] reacted with thumbs up emoji

@XuehaiPanXuehaiPan requested a review fromangelayiJune 1, 2025 18:20
Copy link
Collaborator

@Skylion007Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good once typing is improved

@angelayiangelayi requested a review fromyushangdiJune 2, 2025 16:21
Copy link
Contributor

@angelayiangelayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks so much!

narekmalk reacted with thumbs up emoji
@narekmalk
Copy link
ContributorAuthor

@pytorchbot merge

@pytorch-bot
Copy link

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@XuehaiPan
Copy link
Collaborator

@pytorchbot merge

pytorch-bot[bot] and narekmalk reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelJun 4, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper byviewing the failures on hud

Details for Dev Infra teamRaised byworkflow job

Failing merge rule: Core Maintainers

@narekmalk
Copy link
ContributorAuthor

@XuehaiPan can you please retrigger the merge?

@XuehaiPan
Copy link
Collaborator

@pytorchbot merge -r

pytorch-bot[bot] and narekmalk reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job ontorefs/remotes/origin/viable/strict. Check the current statushere

@pytorchmergebot
Copy link
Collaborator

Successfully rebased154674_issue_fix ontorefs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, viagit checkout 154674_issue_fix && git pull --rebase)

@pytorch-botpytorch-botbot removed the ciflow/trunkTrigger trunk jobs on your pull request labelJun 6, 2025
@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelJun 6, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks:Lint / Link checks / lint-xrefs / linux-job

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 5 mandatory check(s) failed. The first few are:

Dig deeper byviewing the failures on hud

Details for Dev Infra teamRaised byworkflow job

Failing merge rule: Core Maintainers

@XuehaiPan
Copy link
Collaborator

@pytorchbot merge -i

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 6 checks:Lint / quick-checks / linux-job,Lint / toc / linux-job,Lint / workflow-checks / linux-job,Lint / Test tools / linux-job,Lint / Link checks / lint-xrefs / linux-job,Lint / Link checks / lint-urls / linux-job

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper byviewing the failures on hud

Details for Dev Infra teamRaised byworkflow job

Failing merge rule: Core Maintainers

@XuehaiPan
Copy link
Collaborator

The tests unexpectedly hang at the step "Calculate Docker image". cc@malfet@seemethere@huydhn

@XuehaiPan
Copy link
Collaborator

@pytorchbot merge -r

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job ontorefs/remotes/origin/viable/strict. Check the current statushere

@pytorchmergebot
Copy link
Collaborator

Successfully rebased154674_issue_fix ontorefs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, viagit checkout 154674_issue_fix && git pull --rebase)

@pytorch-botpytorch-botbot removed the ciflow/trunkTrigger trunk jobs on your pull request labelJun 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Skylion007Skylion007Skylion007 approved these changes

@XuehaiPanXuehaiPanXuehaiPan approved these changes

@angelayiangelayiangelayi approved these changes

@yushangdiyushangdiyushangdi approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Export _in_spec different before and after load

7 participants

@narekmalk@XuehaiPan@pytorchmergebot@Skylion007@angelayi@yushangdi@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp