Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add optional check_pinning argument to _validate_sparse_compressed_tensor/coo_args#154759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
pearu wants to merge5 commits intogh/pearu/115/basefromgh/pearu/115/head

Conversation

@pearu
Copy link
Collaborator

@pearupearu commentedMay 30, 2025
edited
Loading

[ghstack-poisoned]
@pytorch-botpytorch-botbot added the release notes: sparserelease notes category labelMay 30, 2025
@pytorch-bot
Copy link

pytorch-botbot commentedMay 30, 2025
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/154759

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commitb89f50a with merge base9cbbc25 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. Seehttps://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@pearupearu requested a review fromngimelJune 1, 2025 05:27
[ghstack-poisoned]
@ngimel
Copy link
Collaborator

Heads up, if there are any bc problems due to this, I don't think it makes sense to fix, we could just leave things in current state, with no pinning validation on sparse load.

@pearu
Copy link
CollaboratorAuthor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelJun 2, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull requestJun 4, 2025
@github-actionsgithub-actionsbot deleted the gh/pearu/115/head branchJuly 4, 2025 02:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Skylion007Skylion007Skylion007 left review comments

@amjamesamjamesamjames approved these changes

@ngimelngimelngimel approved these changes

Assignees

No one assigned

Labels

ciflow/trunkTrigger trunk jobs on your pull requestMergedopen sourcerelease notes: sparserelease notes categorytopic: not user facingtopic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pearu@ngimel@pytorchmergebot@Skylion007@amjames

[8]ページ先頭

©2009-2025 Movatter.jp