Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[CUDA] Fixes for backwards in memefficient attn for large tensors#154663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Isalia20
Copy link
Collaborator

@Isalia20Isalia20 commentedMay 29, 2025•
edited by pytorch-botbot
Loading

followup to#154029.

@ngimel Backwards had the same problem as well so this PR fixes it and adds support for logsumexp computation in the forward pass.

cc@ptrblck@msaroufim@eqy@jerryzh168

@pytorch-bot
Copy link

pytorch-botbot commentedMay 29, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/154663

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit596e496 with merge base3c74a72 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Isalia20Isalia20 added module: cudaRelated to torch.cuda, and CUDA support in general module: sdpaAll things related to torch.nn.functional.scaled_dot_product_attentiion release notes: cudarelease notes category labelsMay 29, 2025
@Isalia20Isalia20 requested a review fromngimelMay 29, 2025 21:36
Copy link
Collaborator

@Skylion007Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nits

@Isalia20
Copy link
CollaboratorAuthor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelMay 30, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull requestJun 4, 2025
…torch#154663)followup topytorch#154029.@ngimel Backwards had the same problem as well so this PR fixes it and adds support for logsumexp computation in the forward pass.Pull Requestresolved:pytorch#154663Approved by:https://github.com/ngimel
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Skylion007Skylion007Skylion007 left review comments

@ngimelngimelngimel approved these changes

Assignees

No one assigned

Labels

ciflow/trunkTrigger trunk jobs on your pull requestMergedmodule: cudaRelated to torch.cuda, and CUDA support in generalmodule: sdpaAll things related to torch.nn.functional.scaled_dot_product_attentiionopen sourcerelease notes: cudarelease notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Isalia20@pytorchmergebot@Skylion007@ngimel@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp