Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Memory Viz] Add Compile Context to Visualizer#152862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@sraikund16
Copy link
Contributor

Summary: Adds PT2 info to visualizer. Also makes sure we have a case when compile context is not in pickle file.

Test Plan: {F1977637362}

Differential Revision: D74202811

@pytorch-bot
Copy link

pytorch-botbot commentedMay 5, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/152862

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit46c3488 with merge base2b4fe9f (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request wasexported from Phabricator. Differential Revision:D74202811

Summary:Adds PT2 info to visualizer. Also makes sure we have a case when compile context is not in pickle file.Test Plan: {F1977637362}Differential Revision: D74202811
@facebook-github-bot
Copy link
Contributor

This pull request wasexported from Phabricator. Differential Revision:D74202811

@sraikund16sraikund16 added release notes: profilerrelease notes category enhancementNot as big of a feature, but technically not a bug. Should be easy to fix labelsMay 5, 2025
@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelMay 6, 2025
text=`${text}, Total memory used after allocation:${formatSize(
elem.max_allocated_mem,
)}`;
constcontext=elem?.compile_context??'None';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think if statements may be easier to follow when checking elem.compile_context !== null

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I did it this way just because I also want to set the default value as well if it doesn't show up and this is a nice one liner haha

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aaronenyeshiaaronenyeshiaaronenyeshi approved these changes

Assignees

No one assigned

Labels

ciflow/trunkTrigger trunk jobs on your pull requestenhancementNot as big of a feature, but technically not a bug. Should be easy to fixfb-exportedMergedrelease notes: profilerrelease notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sraikund16@facebook-github-bot@pytorchmergebot@aaronenyeshi
[8]ページ先頭
©2009-2025 Movatter.jp