Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ROCm] opportunistic fastatomics - fix build error with newer compilers#152841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@pragupta
Copy link
Collaborator

@praguptapragupta commentedMay 5, 2025•
edited by pytorch-botbot
Loading

@pytorch-bot
Copy link

pytorch-botbot commentedMay 5, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/152841

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure

As of commit59a25de with merge base50fe1b2 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-botpytorch-botbot added module: rocmAMD GPU support for Pytorch release notes: cudarelease notes category labelsMay 5, 2025
@jithunnair-amd
Copy link
Collaborator

@pragupta Is it possible to be a bit more precise about the minimum compiler versions that require this change (or at least the compiler version that definitely needs this change)?

@jithunnair-amdjithunnair-amd added ciflow/inductor-rocmTrigger "inductor" config CI on ROCm ciflow/rocm-mi300Trigger "default" config CI on ROCm MI300 labelsMay 5, 2025
@praguptapragupta marked this pull request as ready for reviewMay 6, 2025 15:31
@jeffdaily
Copy link
Collaborator

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelMay 6, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are:linux-aarch64 / linux-jammy-aarch64-py3.10 / build

Details for Dev Infra teamRaised byworkflow job

@jeffdaily
Copy link
Collaborator

@pytorchbot merge -f "unrelated failures"

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag,bypassing any CI checks (ETA: 1-5 minutes). Please use-f as last resort and instead consider-i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pragupta added a commit to pragupta/pytorch that referenced this pull requestMay 8, 2025
…newer compilers (pytorch#152841)Fixes #ISSUE_NUMBERPull Requestresolved:pytorch#152841Approved by:https://github.com/jeffdaily(cherry picked from commit8faa0b1)
pragupta added a commit to pragupta/pytorch that referenced this pull requestMay 8, 2025
…newer compilers (pytorch#152841)Fixes #ISSUE_NUMBERPull Requestresolved:pytorch#152841Approved by:https://github.com/jeffdaily(cherry picked from commit8faa0b1)
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull requestMay 8, 2025
#2102)…newer compilers (pytorch#152841)Fixes #ISSUE_NUMBERPull Requestresolved:pytorch#152841Approved by:https://github.com/jeffdaily(cherry picked from commit8faa0b1)Fixes #ISSUE_NUMBER
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull requestMay 8, 2025
#2101)…newer compilers (pytorch#152841)Fixes #ISSUE_NUMBERPull Requestresolved:pytorch#152841Approved by:https://github.com/jeffdaily(cherry picked from commit8faa0b1)Fixes #ISSUE_NUMBER
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull requestMay 8, 2025
…d error with newer compilers (#2097)This PR is a cherry-pick of upstream PR:pytorch#152841 + some missing commitsfrom:pytorch#146264
@praguptapragupta deleted the pg-scatter-add-build-main branchAugust 22, 2025 13:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jeffdailyjeffdailyjeffdaily approved these changes

@eqyeqyAwaiting requested review from eqyeqy is a code owner

@syed-ahmedsyed-ahmedAwaiting requested review from syed-ahmedsyed-ahmed is a code owner

Assignees

No one assigned

Labels

ciflow/inductor-rocmTrigger "inductor" config CI on ROCmciflow/rocm-mi300Trigger "default" config CI on ROCm MI300ciflow/trunkTrigger trunk jobs on your pull requestMergedmodule: rocmAMD GPU support for Pytorchopen sourcerelease notes: cudarelease notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pragupta@jithunnair-amd@jeffdaily@pytorchmergebot@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp