Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ONNX] Implement sym_not#152111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@justinchuby
Copy link
Collaborator

@justinchubyjustinchuby commentedApr 24, 2025•
edited
Loading

Implement onnx support for sym_not. Replaces#147472

Fix#136572

@pytorch-bot
Copy link

pytorch-botbot commentedApr 24, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/152111

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit0f76e2c with merge basee2c7ae5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-botpytorch-botbot added the release notes: onnxtorch.onnx related changes that should show up in the release notes labelApr 24, 2025
@justinchubyjustinchuby added module: onnxRelated to torch.onnx release notes: onnxtorch.onnx related changes that should show up in the release notes topic: improvementstopic category and removed release notes: onnxtorch.onnx related changes that should show up in the release notes labelsApr 24, 2025
@titaiwangms
Copy link
Collaborator

I think there might be some authorization issue that we need to ask core maintainer to run CI.



@onnx_impl(torch.sym_not,trace_only=True)
defsym_not(self)->BOOL:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it possible to add a test with dummy model to validate the op is converted?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

@justinchubyjustinchuby added the ciflow/trunkTrigger trunk jobs on your pull request labelApr 25, 2025
@justinchuby
Copy link
CollaboratorAuthor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rec pushed a commit to rec/pytorch that referenced this pull requestApr 25, 2025
Implement onnx support for sym_not. Replacespytorch#147472Fixpytorch#136572Pull Requestresolved:pytorch#152111Approved by:https://github.com/titaiwangms
@titaiwangmstitaiwangms added the topic: new featurestopic category labelJul 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@titaiwangmstitaiwangmstitaiwangms approved these changes

@shubhambhokare1shubhambhokare1Awaiting requested review from shubhambhokare1

@wschinwschinAwaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunkTrigger trunk jobs on your pull requestMergedmodule: onnxRelated to torch.onnxopen sourcerelease notes: onnxtorch.onnx related changes that should show up in the release notestopic: improvementstopic categorytopic: new featurestopic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ONNX] Dynamic shapes: supporttorch.sym_not

4 participants

@justinchuby@titaiwangms@pytorchmergebot@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp