NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

Optimize register_full_backward_hook description when all input no grad#151785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

zeshengzong wants to merge2 commits intopytorch:mainfromzeshengzong:opt/docs/register_full_backward_hook

Closed

Optimize register_full_backward_hook description when all input no grad#151785

zeshengzong wants to merge2 commits intopytorch:mainfromzeshengzong:opt/docs/register_full_backward_hook

Conversation

Copy link

Contributor

zeshengzong commentedApr 21, 2025

Fixes#100528

Test Result

Before

After

Optimize register_full_backward_hook description when all input no grad

597af20

Copy link

pytorch-botbot commentedApr 21, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/151785

📄 PreviewPython docs built from this PR
📄 PreviewC++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit thebot commands wiki or ouroffice hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commitcfc2c1a with merge baseeb1f85a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zeshengzong marked this pull request as ready for review

April 21, 2025 11:20

zeshengzong requested review fromalbanD,jbschlosser andmikaylagawarecki ascode owners

April 21, 2025 11:20

pytorchbot added the open source label

Apr 21, 2025

albanD requested review fromsoulitzer and removed request foralbanD

April 21, 2025 14:21

soulitzer reviewed

Apr 21, 2025

View reviewed changes

Copy link

Contributor

soulitzer left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

But to change up the ordering/wording, maybe I prefer the following structure:

Ordinarily, the hook fires when the gradients are computed with respect to the module inputs.
If none of the module inputs require gradients, the hook will fire when the gradients are computed with respect to module outputs
If none of the module outputs require gradients, then the hooks will not fire.