NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

[fx] Filter stacktrace#151029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

angelayi wants to merge1 commit intomainfromangelayi/filter_stacktrace

Closed

[fx] Filter stacktrace#151029

angelayi wants to merge1 commit intomainfromangelayi/filter_stacktrace

Conversation

Copy link

Contributor

angelayi commentedApr 10, 2025•
edited
Loading

Filtering out the stacktrace so that the stacktrace on nodes when using fx.Tracer looks nicer. I just copied the filtering we have inproxy_tensor.py.

Previously the stacktrace looked like:

File "/data/users/angelayi/pytorch/moo.py", line 3964, in <module>    run_tests()  File "/data/users/angelayi/pytorch/torch/testing/_internal/common_utils.py", line 1342, in run_tests    unittest.main(argv=argv)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/main.py", line 101, in __init__    self.runTests()  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/main.py", line 271, in runTests    self.result = testRunner.run(self.test)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/runner.py", line 184, in run    test(result)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/suite.py", line 84, in __call__    return self.run(*args, **kwds)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/suite.py", line 122, in run    test(result)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/suite.py", line 84, in __call__    return self.run(*args, **kwds)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/suite.py", line 122, in run    test(result)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/case.py", line 650, in __call__    return self.run(*args, **kwds)  File "/data/users/angelayi/pytorch/torch/testing/_internal/common_utils.py", line 3324, in run    self._run_custom(  File "/data/users/angelayi/pytorch/torch/testing/_internal/common_utils.py", line 3296, in _run_custom    super_run(result=result)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/case.py", line 591, in run    self._callTestMethod(testMethod)  File "/home/angelayi/.conda/envs/pytorch-3.10/lib/python3.10/unittest/case.py", line 549, in _callTestMethod    method()  File "/data/users/angelayi/pytorch/torch/testing/_internal/common_utils.py", line 3156, in wrapper    method(*args, **kwargs)  File "/data/users/angelayi/pytorch/moo.py", line 1495, in test_stack_trace    gm = torch.fx.GraphModule(m, tracer.trace(m))  File "/data/users/angelayi/pytorch/torch/fx/_symbolic_trace.py", line 837, in trace    (self.create_arg(fn(*args)),),  File "/data/users/angelayi/pytorch/moo.py", line 1485, in forward    x = x * 2  File "/data/users/angelayi/pytorch/torch/fx/proxy.py", line 716, in impl    return tracer.create_proxy("call_function", target, args, kwargs)  File "/data/users/angelayi/pytorch/torch/fx/proxy.py", line 248, in create_proxy    proxy.node.stack_trace = "".join(CapturedTraceback.extract().format())

Now it looks like:

File "/data/users/angelayi/pytorch/moo.py", line 1485, in forward    x = x * 2

cc@ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

angelayi requested review fromSherlockNoMad andjfix71

April 10, 2025 17:46

angelayi requested a review fromzou3519 as acode owner

April 10, 2025 17:46

pytorch-botbot added the release notes: fxrelease notes category label

Apr 10, 2025

Copy link

pytorch-botbot commentedApr 10, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/151029

📄 PreviewPython docs built from this PR
📄 PreviewC++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit thebot commands wiki or ouroffice hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit9988b11 with merge base7d205b2 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the fx label

Apr 10, 2025

jfix71 approved these changes

Apr 10, 2025

View reviewed changes

Copy link

Contributor

jfix71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 🚀

angelayi force-pushed theangelayi/filter_stacktrace branch fromd4fd83b to84af875Compare

April 10, 2025 23:36

angelayi requested review fromChillee andezyang ascode owners

April 10, 2025 23:36

zou3519 reviewed

Apr 11, 2025

View reviewed changes

Copy link

Contributor

zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

do you have a before and after of the new stack trace?

Copy link

ContributorAuthor

angelayi commentedApr 11, 2025

Updated the PR summary to include the stacktrace!

Skylion007 reviewed

Apr 14, 2025

View reviewed changes

torch/fx/proxy.py Outdated

Comment on lines 267 to 268

		frame.filename.endswith("fx/_symbolic_trace.py")
		orframe.filename.endswith("export/_trace.py")

Copy link

Collaborator

Skylion007Apr 14, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	frame.filename.endswith("fx/_symbolic_trace.py")
	orframe.filename.endswith("export/_trace.py")
	frame.filename.endswith(("fx/_symbolic_trace.py","export/_trace.py"))