Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ONNX] Add asdict method to VerificationInfo class#151024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
justinchuby wants to merge5 commits intomainfromjustinchu/add-asdict-method

Conversation

@justinchuby
Copy link
Collaborator

@justinchubyjustinchuby commentedApr 10, 2025•
edited
Loading

This pull request introduces a new method to convertVerificationInfo objects to dictionaries and includes a corresponding test to ensure the method works correctly.

@pytorch-botpytorch-botbot added the release notes: onnxtorch.onnx related changes that should show up in the release notes labelApr 10, 2025
@pytorch-bot
Copy link

pytorch-botbot commentedApr 10, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/151024

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit2132ee3 with merge base1250106 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@justinchubyjustinchuby added module: onnxRelated to torch.onnx topic: improvementstopic category labelsApr 10, 2025
@justinchubyjustinchuby changed the titleAdd asdict method to VerificationInfo class[ONNX] Add asdict method to VerificationInfo classApr 10, 2025
Copy link
Collaborator

@titaiwangmstitaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would it be helpful to have another test that covers serializing to json?

@justinchuby
Copy link
CollaboratorAuthor

Would it be helpful to have another test that covers serializing to json?

Done

@justinchuby
Copy link
CollaboratorAuthor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelApr 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchubyjustinchuby deleted the justinchu/add-asdict-method branchApril 10, 2025 23:18
timocafe pushed a commit to timocafe/pytorch that referenced this pull requestApr 16, 2025
This pull request introduces a new method to convert `VerificationInfo` objects to dictionaries and includes a corresponding test to ensure the method works correctly.Pull Requestresolved:pytorch#151024Approved by:https://github.com/titaiwangms
amathewc pushed a commit to amathewc/pytorch that referenced this pull requestApr 17, 2025
This pull request introduces a new method to convert `VerificationInfo` objects to dictionaries and includes a corresponding test to ensure the method works correctly.Pull Requestresolved:pytorch#151024Approved by:https://github.com/titaiwangms
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@titaiwangmstitaiwangmstitaiwangms approved these changes

@shubhambhokare1shubhambhokare1Awaiting requested review from shubhambhokare1

@wschinwschinAwaiting requested review from wschin

Assignees

No one assigned

Labels

ciflow/trunkTrigger trunk jobs on your pull requestMergedmodule: onnxRelated to torch.onnxopen sourcerelease notes: onnxtorch.onnx related changes that should show up in the release notestopic: improvementstopic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby@pytorchmergebot@titaiwangms@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp