Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add batching rule fortorch.Tensor.scatter_add_#150543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobasguilhermeleobas commentedApr 2, 2025•
edited by pytorch-botbot
Loading

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-botbot commentedApr 2, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/150543

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit3311987 with merge base3da14d3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guilhermeleobas added a commit that referenced this pull requestApr 2, 2025
@guilhermeleobasguilhermeleobas added the module: functorchPertaining to torch.func or pytorch/functorch labelApr 2, 2025
@guilhermeleobasguilhermeleobas linked an issueApr 2, 2025 that may beclosed by this pull request
@guilhermeleobasguilhermeleobas added the release notes: torch.funcrelease notes category for torch.vmap or torch.func.* APIs labelApr 2, 2025
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull requestApr 2, 2025
@guilhermeleobasguilhermeleobas self-assigned thisApr 2, 2025
@guilhermeleobasguilhermeleobas marked this pull request as ready for reviewApril 2, 2025 19:45
int64_t dim,
const Tensor& index, std::optional<int64_t> index_bdim,
const Tensor& src, std::optional<int64_t> src_bdim) {
auto self_ = self.clone(at::MemoryFormat::Preserve);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why do we need the clone now?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't.

[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull requestApr 7, 2025
@guilhermeleobas
Copy link
CollaboratorAuthor

@pytorchbot merge -r

pytorch-bot[bot] reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelApr 8, 2025
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job ontorefs/remotes/origin/viable/strict. Check the current statushere

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebasedgh/guilhermeleobas/117/orig ontorefs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, viaghstack checkout https://github.com/pytorch/pytorch/pull/150543)

pytorchmergebot pushed a commit that referenced this pull requestApr 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

timocafe pushed a commit to timocafe/pytorch that referenced this pull requestApr 16, 2025
amathewc pushed a commit to amathewc/pytorch that referenced this pull requestApr 17, 2025
@github-actionsgithub-actionsbot deleted the gh/guilhermeleobas/117/head branchMay 16, 2025 02:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zou3519zou3519zou3519 approved these changes

@ChilleeChilleeAwaiting requested review from Chillee

@kshitij12345kshitij12345Awaiting requested review from kshitij12345

@mruberrymruberryAwaiting requested review from mruberry

Assignees

@guilhermeleobasguilhermeleobas

Labels

ciflow/trunkTrigger trunk jobs on your pull requestMergedmodule: functorchPertaining to torch.func or pytorch/functorchopen sourcerelease notes: torch.funcrelease notes category for torch.vmap or torch.func.* APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

batching rule foraten::scatter_add_

5 participants

@guilhermeleobas@pytorchmergebot@zou3519@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp