- Notifications
You must be signed in to change notification settings - Fork26.3k
[PP] Add schedule visualizer#150347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[PP] Add schedule visualizer#150347
Uh oh!
There was an error while loading.Please reload this page.
Conversation
[ghstack-poisoned]
pytorch-botbot commentedMar 31, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🔗 Helpful Links🧪 See artifacts and rendered test results athud.pytorch.org/pr/150347
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commitaad56b1 with merge base47cdad2 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Added a new private file (`_schedule_visualizer.py`) with some helper methods that can be used to visualize the operations of a schedule and plot with matplotlib.InterleavedZeroBubble(pp_group=4, microbatches=8):cc awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o[ghstack-poisoned]
kwen2501 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great! Thank you!
Uh oh!
There was an error while loading.Please reload this page.
| if __name__ == "__main__": | ||
| # Example usage: | ||
| ops = get_schedule_ops("InterleavedZeroBubble", 4, 8) | ||
| visualize_schedule(ops, "test.png") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we can write the example in comment format rather than under__main__ ?
| def get_schedule_ops( | ||
| schedule: Union[str, _PipelineSchedule], | ||
| pp_degree: int, | ||
| num_microbatches: int, | ||
| num_stages_per_rank: Optional[int] = None, | ||
| ) -> list[list[Optional[_Action]]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add a short comment to this function? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
will add, thanks
| def visualize_schedule( | ||
| schedule: list[list[Optional[_Action]]], filename: Optional[str] = None | ||
| ) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
will do
Added a new private file (`_schedule_visualizer.py`) with some helper methods that can be used to visualize the operations of a schedule and plot with matplotlib.InterleavedZeroBubble(pp_group=4, microbatches=8):cc awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o[ghstack-poisoned]
H-Huang commentedApr 14, 2025
@pytorchbot merge |
pytorchmergebot commentedApr 14, 2025
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in thewiki. Questions? Feedback? Please reach out to thePyTorch DevX Team |
pytorchmergebot commentedApr 14, 2025
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper byviewing the failures on hud |
H-Huang commentedApr 14, 2025
@pytorchbot merge -i |
pytorchmergebot commentedApr 14, 2025
Merge startedYour change will be merged while ignoring the following 3 checks:pull / unstable-linux-focal-cuda12.6-py3.10-gcc11-sm89-xfail / build,pull / cuda12.4-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu),trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-15) Learn more about merging in thewiki. Questions? Feedback? Please reach out to thePyTorch DevX Team |
Added a new private file (`_schedule_visualizer.py`) with some helper methods that can be used to visualize the operations of a schedule and plot with matplotlib.InterleavedZeroBubble(pp_group=4, microbatches=8):Pull Requestresolved:pytorch#150347Approved by:https://github.com/kwen2501
Added a new private file (`_schedule_visualizer.py`) with some helper methods that can be used to visualize the operations of a schedule and plot with matplotlib.InterleavedZeroBubble(pp_group=4, microbatches=8):Pull Requestresolved:pytorch#150347Approved by:https://github.com/kwen2501
ghstack-source-id:4027b46Pull Requestresolved:pytorch/pytorch#150347
Uh oh!
There was an error while loading.Please reload this page.
Stack fromghstack (oldest at bottom):
Added a new private file (
_schedule_visualizer.py) with some helper methods that can be used to visualize the operations of a schedule and plot with matplotlib.InterleavedZeroBubble(pp_group=4, microbatches=8):
cc@awgu@kwen2501@wanchaol@fegin@fduwjj@wz337@wconstab@d4l3k@c-p-i-o