Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AOTI] Add num_runners to AOTIModelPackageLoader#149364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@desertfire
Copy link
Contributor

@desertfiredesertfire commentedMar 18, 2025•
edited
Loading

Stack fromghstack (oldest at bottom):

Summary: AOTIModelContainerRunner takes a num_runners argument for multi-threaded inference, but AOTIModelPackageLoader forgot to take the same parameter, although its run() API already expects to take an optional cudaStream_t parameter for multi-threaded inference.

cc@voznesenskym@penguinwu@EikanWang@jgong5@Guobing-Chen@XiaobingSuper@zhuhaozhe@blzheng@wenzhe-nrv@jiayisunx@ipiszy@chenyang78@kadeng@muchulee8@amjames@chauhang@aakhundov

Differential Revision:D71357418

Summary: AOTIModelContainerRunner takes a num_runners argument for multi-threaded inference, but AOTIModelPackageLoader forgot to take the same parameter, although its run() API already expects to take an optional cudaStream_t parameter for multi-threaded inference.[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-botbot commentedMar 18, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/149364

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commitc0ccb40 with merge basefdacf3c (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

desertfire added a commit that referenced this pull requestMar 18, 2025
Summary: AOTIModelContainerRunner takes a num_runners argument for multi-threaded inference, but AOTIModelPackageLoader forgot to take the same parameter, although its run() API already expects to take an optional cudaStream_t parameter for multi-threaded inference.ghstack-source-id:1e414d1Pull Requestresolved:#149364
@desertfire
Copy link
ContributorAuthor

@desertfire has imported this pull request. If you are a Meta employee, you can view this diffon Phabricator.

Summary: AOTIModelContainerRunner takes a num_runners argument for multi-threaded inference, but AOTIModelPackageLoader forgot to take the same parameter, although its run() API already expects to take an optional cudaStream_t parameter for multi-threaded inference.cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundovDifferential Revision: [D71357418](https://our.internmc.facebook.com/intern/diff/D71357418)[ghstack-poisoned]
desertfire added a commit that referenced this pull requestMar 18, 2025
Summary: AOTIModelContainerRunner takes a num_runners argument for multi-threaded inference, but AOTIModelPackageLoader forgot to take the same parameter, although its run() API already expects to take an optional cudaStream_t parameter for multi-threaded inference.ghstack-source-id:3836f60Pull Requestresolved:#149364
@desertfire
Copy link
ContributorAuthor

@desertfire has imported this pull request. If you are a Meta employee, you can view this diffon Phabricator.

Summary: AOTIModelContainerRunner takes a num_runners argument for multi-threaded inference, but AOTIModelPackageLoader forgot to take the same parameter, although its run() API already expects to take an optional cudaStream_t parameter for multi-threaded inference.cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundovDifferential Revision: [D71357418](https://our.internmc.facebook.com/intern/diff/D71357418)[ghstack-poisoned]
desertfire added a commit that referenced this pull requestMar 18, 2025
Summary: AOTIModelContainerRunner takes a num_runners argument for multi-threaded inference, but AOTIModelPackageLoader forgot to take the same parameter, although its run() API already expects to take an optional cudaStream_t parameter for multi-threaded inference.ghstack-source-id:ccac029Pull Requestresolved:#149364
@desertfire
Copy link
ContributorAuthor

@desertfire has imported this pull request. If you are a Meta employee, you can view this diffon Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actionsgithub-actionsbot deleted the gh/desertfire/556/head branchApril 22, 2025 02:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@angelayiangelayiangelayi approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@desertfire@facebook-github-bot@pytorchmergebot@angelayi
[8]ページ先頭
©2009-2025 Movatter.jp