NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

[DTensor] Fix`local_map` with multi-threading#149070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

awgu wants to merge2 commits intopytorch:mainfromawgu:local_map

Closed

[DTensor] Fix`local_map` with multi-threading#149070

awgu wants to merge2 commits intopytorch:mainfromawgu:local_map

Conversation

Copy link

Collaborator

awgu commentedMar 12, 2025•
edited by pytorch-botbot
Loading

Usingnonlocal device_mesh is not safe with multi-threading

cc@H-Huang @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

[DTensor] Fixlocal_map with multi-threading

7b2d255

Copy link

pytorch-botbot commentedMar 12, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/149070

📄 PreviewPython docs built from this PR
📄 PreviewC++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit thebot commands wiki or ouroffice hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit7eb4b39 with merge base492f3fd ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-botbot added the oncall: distributedAdd this issue/PR to distributed oncall triage queue label

Mar 12, 2025

pytorchbot added the open source label

Mar 12, 2025

wanchaol added the release notes: distributed (dtensor)release notes category label

Mar 12, 2025

wanchaol approved these changes

Mar 12, 2025

View reviewed changes

Copy link

Collaborator

wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm!

Fix lint

7eb4b39

Copy link

CollaboratorAuthor

awgu commentedMar 13, 2025

@pytorchbot merge

pytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request label

Mar 13, 2025

pytorchmergebot added the merging label

Mar 13, 2025

Copy link

Collaborator

pytorchmergebot commentedMar 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Copy link

Collaborator

pytorchmergebot commentedMar 13, 2025

The mergejob was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information seepytorch-bot wiki.