Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Expand docs fornn.functional, and make the wording consistent#148436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
olipinski wants to merge2 commits intopytorch:mainfromolipinski:functional-docs

Conversation

@olipinski
Copy link
Contributor

Expands the docs for the loss functions, and makes the wording consistent.

Fixes#148353

@pytorch-bot
Copy link

pytorch-botbot commentedMar 4, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/148436

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit80b5039 with merge base1a1a32c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easyclabot commentedMar 4, 2025•
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@olipinskiolipinskiforce-pushed thefunctional-docs branch 2 times, most recently from2ad95f4 tof59c238CompareMarch 4, 2025 14:07
@olipinskiolipinski marked this pull request as ready for reviewMarch 4, 2025 14:12
@colesburycolesbury added the triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module labelMar 6, 2025
@colesburycolesbury requested a review fromsvekarsMarch 6, 2025 18:43
Copy link
Collaborator

@albanDalbanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for take the time to go over this!

olipinski reacted with thumbs up emoji
@albanD
Copy link
Collaborator

@pytorchbot merge -r

@pytorch-bot
Copy link

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@olipinski
Copy link
ContributorAuthor

Hi@albanD, it seems the merge won't go through without the labels, but I don't think I can add them myself, so I have requested re-review.

albanD reacted with thumbs up emoji

@olipinskiolipinski requested a review fromalbanDApril 12, 2025 08:43
@albanDalbanD added release notes: nnrelease notes category topic: docstopic category labelsApr 14, 2025
@albanD
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot
Copy link

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@huydhn
Copy link
Contributor

@pytorchbot rebase

pytorch-bot[bot] reacted with thumbs up emoji

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job ontorefs/remotes/origin/viable/strict. Check the current statushere

Fix HuberLoss consistencySigned-off-by: Olaf Lipinski <o.lipinski@soton.ac.uk>
Signed-off-by: Olaf Lipinski <o.lipinski@soton.ac.uk>
@pytorchmergebot
Copy link
Collaborator

Successfully rebasedfunctional-docs ontorefs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, viagit checkout functional-docs && git pull --rebase)

@huydhn
Copy link
Contributor

@pytorchbot merge

pytorch-bot[bot] reacted with thumbs up emoji

@pytorch-botpytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request labelApr 14, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

timocafe pushed a commit to timocafe/pytorch that referenced this pull requestApr 16, 2025
…orch#148436)Expands the docs for the loss functions, and makes the wording consistent.Fixespytorch#148353Pull Requestresolved:pytorch#148436Approved by:https://github.com/albanD
amathewc pushed a commit to amathewc/pytorch that referenced this pull requestApr 17, 2025
…orch#148436)Expands the docs for the loss functions, and makes the wording consistent.Fixespytorch#148353Pull Requestresolved:pytorch#148436Approved by:https://github.com/albanD
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@albanDalbanDalbanD approved these changes

@jbschlosserjbschlosserAwaiting requested review from jbschlosserjbschlosser is a code owner

@mikaylagawareckimikaylagawareckiAwaiting requested review from mikaylagawareckimikaylagawarecki is a code owner

@svekarssvekarsAwaiting requested review from svekars

Assignees

No one assigned

Labels

ciflow/trunkTrigger trunk jobs on your pull requestMergedopen sourcerelease notes: nnrelease notes categorytopic: docstopic categorytriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.nn.functional inconsistent documentation

6 participants

@olipinski@albanD@huydhn@pytorchmergebot@colesbury@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp