NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

[ONNX] Adjust and add deprecation messages#146639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

justinchuby wants to merge12 commits intopytorch:mainfromjustinchuby:justinchu/deprecation4

Closed

[ONNX] Adjust and add deprecation messages#146639

justinchuby wants to merge12 commits intopytorch:mainfromjustinchuby:justinchu/deprecation4

Conversation

Copy link

Collaborator

justinchuby commentedFeb 6, 2025•
edited
Loading

Adjust and add deprecation messages to torch.onnx utilities and verification methods because they are only related to torch script and are obsolete.

Removed unused_exporter_states.py and removed the internal deprecation module in favor of the typing_extensions deprecated decorator.

Copy link

pytorch-botbot commentedFeb 6, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/146639

📄 PreviewPython docs built from this PR
📄 PreviewC++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit thebot commands wiki or ouroffice hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit6e50139 with merge base41e6d18 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-botbot added the release notes: onnxtorch.onnx related changes that should show up in the release notes label

Feb 6, 2025

justinchuby changed the title~~[ONNX] Create deprecation warning on dynamo_export~~[ONNX] Deprecate old features

Feb 6, 2025

pytorchbot added the open source label

Feb 6, 2025

justinchuby added7 commits

February 6, 2025 20:23

Deprecate

0255f48

log

c1f46c2

wording

f63a62b

docs

173178d

msg

b874455

Remove exporter states

f63c04a

Update warnings

b024438

justinchuby force-pushed thejustinchu/deprecation4 branch from4bd5dbc tob024438Compare

February 7, 2025 04:28

justinchuby changed the title~~[ONNX] Deprecate old features~~[ONNX] Adjust and add deprecation messages

Feb 7, 2025

justinchuby mentioned this pull request

Feb 7, 2025

[ONNX] Improve deprecation messages#146469

Closed

5 tasks

justinchuby marked this pull request as ready for review

February 7, 2025 04:29

justinchuby requested review fromshubhambhokare1,titaiwangms andwschin ascode owners

February 7, 2025 04:29

justinchuby added2 commits

February 6, 2025 20:30

logging

15f7d81

unconvertible_ops

c430a73

justinchuby added module: onnx

Related to torch.onnx

topic: deprecationtopic category labels

Feb 7, 2025

titaiwangms approved these changes

Feb 7, 2025

View reviewed changes

Copy link

Collaborator

titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why are we removing category

Copy link

CollaboratorAuthor

justinchuby commentedFeb 7, 2025•
edited
Loading

Why are we removing category

That's because I realized DeprecationWarning is the default:https://docs.python.org/3/library/warnings.html#warnings.deprecated

Copy link

CollaboratorAuthor

justinchuby commentedFeb 7, 2025

@pytorchbot merge

pytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request label

Feb 7, 2025

pytorchmergebot added the merging label

Feb 7, 2025

Copy link

Collaborator

pytorchmergebot commentedFeb 7, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Copy link

Collaborator

pytorchmergebot commentedFeb 7, 2025

The mergejob was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information seepytorch-bot wiki.

Messages

c83a0c9

justinchuby added2 commits

February 7, 2025 10:34

Docs

304da3d

remove module

6e50139

Copy link

CollaboratorAuthor

justinchuby commentedFeb 7, 2025

@pytorchbot merge

Copy link

Collaborator

pytorchmergebot commentedFeb 7, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Copy link

Collaborator

pytorchmergebot commentedFeb 8, 2025

Copy link

CollaboratorAuthor

justinchuby commentedFeb 8, 2025

@pytorchbot merge -f "rocm timed out"

Copy link

Collaborator

pytorchmergebot commentedFeb 8, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag,bypassing any CI checks (ETA: 1-5 minutes). Please use-f as last resort and instead consider-i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in63c2909

Feb 8, 2025

pytorchmergebot added Merged and removed merging labels

Feb 8, 2025

Copy link

Contributor

atalman commentedFeb 10, 2025

@pytorchmergebot revert -c ghfirst -m "Sorry Need to revert#146425"

Copy link

Collaborator

pytorchmergebot commentedFeb 10, 2025

@pytorchbot successfully started a revert job. Check the current statushere.
Questions? Feedback? Please reach out to thePyTorch DevX Team

Copy link

Collaborator

pytorchmergebot commentedFeb 10, 2025

@justinchuby your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request

Feb 10, 2025

Revert "[ONNX] Adjust and add deprecation messages (#146639)"

1557b7b

This reverts commit63c2909.Reverted#146639 on behalf ofhttps://github.com/atalman due to Sorry Need to revert#146425 ([comment](#146639 (comment)))

pytorchmergebot added Reverted ci-no-tdDo not run TD on this PR labels

Feb 10, 2025

pytorchmergebot reopened this

Feb 10, 2025

justinchuby added a commit to justinchuby/pytorch that referenced this pull request

Feb 11, 2025

[ONNX] Adjust and add deprecation messages (pytorch#146639)

e2b1313

Adjust and add deprecation messages to torch.onnx utilities and verification methods because they are only related to torch script and are obsolete.Removed unused `_exporter_states.py` and removed the internal deprecation module in favor of the typing_extensions deprecated decorator.Pull Requestresolved:pytorch#146639Approved by:https://github.com/titaiwangms

justinchuby mentioned this pull request

Feb 11, 2025

[ONNX][reland2] Create deprecation warning on dynamo_export#146923

Closed

Copy link

CollaboratorAuthor

justinchuby commentedFeb 11, 2025

Replaced by#146923

justinchuby closed this

Feb 11, 2025

pytorchmergebot pushed a commit that referenced this pull request

Feb 12, 2025

[ONNX][reland2] Create deprecation warning on dynamo_export (#146923)

7f62616

Reland two PRs-#146425-#146639Fixed by removing the deprecation warning on a base class `ExportOptions`.Pull Requestresolved:#146923Approved by:https://github.com/titaiwangms

Raymo111 pushed a commit that referenced this pull request

Feb 20, 2025

[ONNX] Adjust and add deprecation messages (#146639)

614fb19

Adjust and add deprecation messages to torch.onnx utilities and verification methods because they are only related to torch script and are obsolete.Removed unused `_exporter_states.py` and removed the internal deprecation module in favor of the typing_extensions deprecated decorator.Pull Requestresolved:#146639Approved by:https://github.com/titaiwangms

Raymo111 pushed a commit that referenced this pull request

Feb 20, 2025

Revert "[ONNX] Adjust and add deprecation messages (#146639)"

6d74c8f

This reverts commit63c2909.Reverted#146639 on behalf ofhttps://github.com/atalman due to Sorry Need to revert#146425 ([comment](#146639 (comment)))

Raymo111 pushed a commit that referenced this pull request

Feb 20, 2025

[ONNX][reland2] Create deprecation warning on dynamo_export (#146923)

c4d530d

Reland two PRs-#146425-#146639Fixed by removing the deprecation warning on a base class `ExportOptions`.Pull Requestresolved:#146923Approved by:https://github.com/titaiwangms

majing921201 pushed a commit to majing921201/pytorch that referenced this pull request

Mar 4, 2025

Revert "[ONNX] Adjust and add deprecation messages (pytorch#146639)"

87f0412

This reverts commit63c2909.Revertedpytorch#146639 on behalf ofhttps://github.com/atalman due to Sorry Need to revertpytorch#146425 ([comment](pytorch#146639 (comment)))

majing921201 pushed a commit to majing921201/pytorch that referenced this pull request

Mar 4, 2025

[ONNX][reland2] Create deprecation warning on dynamo_export (pytorch#…

3c25f72

…146923)Reland two PRs-pytorch#146425-pytorch#146639Fixed by removing the deprecation warning on a base class `ExportOptions`.Pull Requestresolved:pytorch#146923Approved by:https://github.com/titaiwangms