NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

Let`tensor_a.new_tensor()` be on`tensor_a.device` by default#144958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

oraluben wants to merge5 commits intopytorch:mainfromoraluben:tensor-new_tensor-device

Closed

Let`tensor_a.new_tensor()` be on`tensor_a.device` by default#144958

oraluben wants to merge5 commits intopytorch:mainfromoraluben:tensor-new_tensor-device

Conversation

Copy link

Contributor

oraluben commentedJan 16, 2025•
edited by pytorch-botbot
Loading

Fixes#144957
Closes#73838 cc@albanD @ezyang

Currently,tensor_a.new_tensor() will return a on-cpu tensor no matter where istensor_a. This differs from the document and is a side-effect of#41984.

See#144957 how current logic breaks dynamo.

This PR restore the documented behavior and add tests fornew_tensor.

Copy link

pytorch-botbot commentedJan 16, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/144958

📄 PreviewPython docs built from this PR
📄 PreviewC++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit thebot commands wiki or ouroffice hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit8868a78 with merge based2a77f4 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh) (disabled by#131083 but the issue was closed recently and a rebase is needed to make it pass)
export/test_retraceability.py::RetraceExportTestExport::test_slice_with_floordiv_retraceability
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh) (disabled by#131082,#131083,#131088,#131101,#131119,#131136,#138675,#138884 but the issue was closed recently and a rebase is needed to make it pass)
export/test_export.py::TestExport::test_slice_with_floordiv

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

ContributorAuthor

oraluben commentedJan 16, 2025

@pytorchbot label "topic: bc breaking"

pytorch-botbot added the topic: bc breakingtopic category label

Jan 16, 2025

pytorchbot added the open source label

Jan 16, 2025

tensor_a.new_tensor() should be ontensor_a.device by default

101652b

oraluben force-pushed thetensor-new_tensor-device branch from00bcb32 to101652bCompare

January 16, 2025 10:47

add test

bfdaeab

oraluben force-pushed thetensor-new_tensor-device branch fromba615d3 tobfdaeabCompare

January 16, 2025 11:00

oraluben mentioned this pull request

Jan 16, 2025

Inconsistency oftensor.new_tensor(data) between eager and dynamo#144957

Closed

oraluben added3 commits

January 16, 2025 19:23

update

8a931bf

update test

0c7bd66

Merge remote-tracking branch 'upstream/viable/strict' into tensor-new…

8868a78

…_tensor-device

mikaylagawarecki requested a review fromezyang

January 22, 2025 15:34

mikaylagawarecki added the triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module label

Jan 22, 2025

ezyang approved these changes

Jan 24, 2025

View reviewed changes

Copy link

Contributor

ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice catch

Copy link

Contributor

ezyang commentedJan 24, 2025

@pytorchbot merge

pytorch-botbot added the ciflow/trunkTrigger trunk jobs on your pull request label

Jan 24, 2025

pytorchmergebot added the merging label

Jan 24, 2025

Copy link

Collaborator

pytorchmergebot commentedJan 24, 2025

Merge failed

Reason: This PR needs arelease notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting withrelease notes:.

If not, please add thetopic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised byworkflow job

pytorchmergebot removed the merging label

Jan 24, 2025

pytorch-botbottemporarily deployed to upload-benchmark-results

January 24, 2025 17:27

Inactive

pytorch-botbottemporarily deployed to upload-benchmark-results

January 24, 2025 17:27

Inactive

pytorch-botbottemporarily deployed to upload-benchmark-results

January 24, 2025 17:27

Inactive

ezyang added the module: python frontendFor issues relating to PyTorch's Python frontend label

Jan 24, 2025

Copy link

Contributor

ezyang commentedJan 24, 2025

@pytorchbot merge

pytorchmergebot added the merging label

Jan 24, 2025

Copy link

Collaborator

pytorchmergebot commentedJan 24, 2025

Merge failed

Reason: This PR needs arelease notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting withrelease notes:.

If not, please add thetopic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised byworkflow job

pytorchmergebot removed the merging label

Jan 24, 2025

ezyang added the release notes: python_frontendpython frontend release notes category label

Jan 24, 2025

Copy link

Contributor

ezyang commentedJan 24, 2025

@pytorchbot merge

pytorchmergebot added the merging label

Jan 24, 2025

Copy link

Collaborator

pytorchmergebot commentedJan 24, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in thewiki.

Questions? Feedback? Please reach out to thePyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

Jan 24, 2025

pytorchmergebot closed this ind4171b7

Jan 24, 2025

pytorchmergebot removed the merging label

Jan 24, 2025

oraluben deleted the tensor-new_tensor-device branch

January 25, 2025 09:33

nWEIdia pushed a commit to nWEIdia/pytorch that referenced this pull request

Jan 27, 2025

Lettensor_a.new_tensor()be ontensor_a.deviceby default (pytor…

83eab20

…ch#144958)Fixespytorch#144957Closespytorch#73838 cc@albanD@ezyangCurrently, `tensor_a.new_tensor()` will return a on-cpu tensor no matter where is `tensor_a`. This differs from the document and is a side-effect ofpytorch#41984.Seepytorch#144957 how current logic breaks dynamo.This PR restore the documented behavior and add tests for `new_tensor`.Pull Requestresolved:pytorch#144958Approved by:https://github.com/ezyang