Commitecc3718

driazati

authored and

facebook-github-bot

committed

Fix clang-tidy path filtering (#60225)

Summary:PR#60048 neglected to include the `--paths` option for file filtering, so it ended up passing every changed file in the diff to clang-tidy (cpp files outside `torch/csrc/`, yaml/sh files, etc.). This adds that back in to make the filtering work properly again.Tested it manually by printing out the files to lint and running```bashcurl -Lhttps://github.com/pytorch/pytorch/pull/60018.diff > diffpython tools/clang_tidy.py --diff-file diff --paths torch/csrc/curl -Lhttps://github.com/pytorch/pytorch/pull/60222.diff > diffpython tools/clang_tidy.py --diff-file diff --paths torch/csrc/```Shouldfix#60192 andfix#60193, the files tripping errors there shouldn't have been passed to clang-tidy in the first place (supporting aten/ for clang-tidy is a separate task)Pull Requestresolved:#60225Reviewed By: zhouzhuojieDifferential Revision: D29216251Pulled By: driazatifbshipit-source-id: b5d7fb7161d33eb7958a6f1ccc25809942045209

1 parent38c3116 commitecc3718Copy full SHA for ecc3718

File tree

1 file changed

-1

lines changed

tools
- clang_tidy.py

1 file changed

-1

lines changed

`‎tools/clang_tidy.py‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,6 @@ def find_changed_lines(diff: str) -> Dict[str, List[Tuple[int, int]]]:`
`142`	`142`	`forfile,start,endinmatches:`
`143`	`143`	`start_line,_=start.split(",")`
`144`	`144`	`end_line,_=end.split(",")`
`145`		`-print(file,start_line,end_line)`
`146`	`145`
`147`	`146`	`files[file].append((start_line,end_line))`
`148`	`147`
`@@ -330,6 +329,11 @@ def main() -> None:`
`330`	`329`	`ifoptions.diff_file:`
`331`	`330`	`withopen(options.diff_file,"r")asf:`
`332`	`331`	`changed_files=find_changed_lines(f.read())`
	`332`	`+changed_files= {`
	`333`	`+filename:v`
	`334`	`+forfilename,vinchanged_files.items()`
	`335`	`+ifany(filename.startswith(path)forpathinoptions.paths)`
	`336`	`+ }`
`333`	`337`	`line_filters= [`
`334`	`338`	`{"name":name,"lines":lines}forname,lines,inchanged_files.items()`
`335`	`339`	`]`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitecc3718

File tree

1 file changed

1 file changed

`‎tools/clang_tidy.py‎`

0 commit comments