Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support aten.diagonal converter#2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chohk88 merged 3 commits intomainfromaten_diagonal_converter
May 30, 2024
Merged

Conversation

@chohk88
Copy link
Collaborator

@chohk88chohk88 commentedMay 22, 2024•
edited
Loading

Description

A converter for the torch.ops.aten.diagonal operation. There are very good reference for aten.diagonal operation (https://github.com/pytorch/pytorch/blob/082251e76b93b277ff2791d0e2b64934add34644/torch/_refs/__init__.py#L4255 )

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88chohk88 added the component: convertersIssues re: Specific op converters labelMay 22, 2024
@chohk88chohk88 self-assigned thisMay 22, 2024
@github-actionsgithub-actionsbot added component: testsIssues re: Tests component: conversionIssues re: Conversion stage component: api [Python]Issues re: Python API component: dynamoIssues relating to the `torch.compile` or `torch._dynamo.export` paths labelsMay 22, 2024
@github-actionsgithub-actionsbot requested a review fromperi044May 22, 2024 13:33
Copy link
Collaborator

@zewenli98zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall LGTM, just added some comments for your reference.

Copy link
Collaborator

@zewenli98zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@chohk88chohk88 merged commit2cc80d8 intomainMay 30, 2024
This was linked to issuesMay 31, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zewenli98zewenli98zewenli98 approved these changes

@apboseapboseAwaiting requested review from apbose

@gs-olivegs-oliveAwaiting requested review from gs-olive

@peri044peri044Awaiting requested review from peri044

Assignees

@chohk88chohk88

Labels

cla signedcomponent: api [Python]Issues re: Python APIcomponent: conversionIssues re: Conversion stagecomponent: convertersIssues re: Specific op converterscomponent: dynamoIssues relating to the `torch.compile` or `torch._dynamo.export` pathscomponent: testsIssues re: Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aten.diagonal ↔ [Converter] Add support for aten.diagonal

4 participants

@chohk88@zewenli98@facebook-github-bot
[8]ページ先頭
©2009-2025 Movatter.jp