- Notifications
You must be signed in to change notification settings - Fork371
Remove ops from decompositions where converters exist#2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
facebook-github-bot commentedMar 10, 2024
Hi@HolyWu! Thank you for your pull request and welcome to our community. Action RequiredIn order to mergeany pull request (code, docs, etc.), werequire contributors to sign ourContributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign athttps://code.facebook.com/cla.If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, thepull request will be tagged with If you have received this in error or have any questions, please contact us atcla@meta.com. Thanks! |
facebook-github-bot commentedMar 10, 2024
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
apbose commentedMar 12, 2024
Thanks for pointing this out and the above changes!
|
apbose commentedApr 5, 2024
Looks good to me, pending on CI |
Description
The last removed
aten.var_meandoesn't have a converter, but it's a duplicate in the list, so I remove it as well.Partially#2665
Type of change
Checklist: