Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove ops from decompositions where converters exist#2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
apbose merged 1 commit intopytorch:mainfromHolyWu:decomp
May 30, 2024
Merged

Remove ops from decompositions where converters exist#2681

apbose merged 1 commit intopytorch:mainfromHolyWu:decomp
May 30, 2024

Conversation

@HolyWu
Copy link
Contributor

Description

The last removedaten.var_mean doesn't have a converter, but it's a duplicate in the list, so I remove it as well.

Partially#2665

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@facebook-github-bot
Copy link
Contributor

Hi@HolyWu!

Thank you for your pull request and welcome to our community.

Action Required

In order to mergeany pull request (code, docs, etc.), werequire contributors to sign ourContributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign athttps://code.facebook.com/cla.If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, thepull request will be tagged withCLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us atcla@meta.com. Thanks!

@github-actionsgithub-actionsbot added component: loweringIssues re: The lowering / preprocessing passes component: api [Python]Issues re: Python API component: dynamoIssues relating to the `torch.compile` or `torch._dynamo.export` paths labelsMar 10, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@apbose
Copy link
Collaborator

Thanks for pointing this out and the above changes!
Couple of points-

  1. grid_sampler_2dwould require some additional changes
  2. As pointed out by you (thanks!),upsample cases do not seem to be direct enough. But removal of the above decomposition should be good for now.

@narendasannarendasan requested review fromapbose and removed request forperi044March 22, 2024 01:06
@apbose
Copy link
Collaborator

Looks good to me, pending on CI

@apboseapbose merged commit6cc61b4 intopytorch:mainMay 30, 2024
@HolyWuHolyWu deleted the decomp branchMay 31, 2024 10:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@apboseapboseapbose approved these changes

@gs-olivegs-oliveAwaiting requested review from gs-olive

Assignees

No one assigned

Labels

cla signedcomponent: api [Python]Issues re: Python APIcomponent: dynamoIssues relating to the `torch.compile` or `torch._dynamo.export` pathscomponent: loweringIssues re: The lowering / preprocessing passes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HolyWu@facebook-github-bot@apbose@narendasan

[8]ページ先頭

©2009-2025 Movatter.jp