- Notifications
You must be signed in to change notification settings - Fork384
Open
Conversation
dxe4 commentedNov 2, 2019
| if self.backend == 'guppy': | ||
| if self.prevlines[-1] == self.prev_lineno: | ||
| # the reason for this is because for code like [i for i in range(0, 1000000)] guppy will be extremely slow | ||
| _run = False |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this can cause issues if you want to measure the memory of a side effect eg
[foo() for i in range(0, 500)]def foo(): make_big_array = [i for i in random.randint(0, int(1e9))]i haven't tested it.
although it will give correct results for this case#236 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to my comment here#236 (comment)
with implementation of guppy3 we can get the right values.
note this implementation does
self.prevlines[-1] == self.prev_lineno:for guppy backend only, because repeating[i for i in range(0, 10000000)]makes the guppy backend extremely slow. although this may not be ideal or acceptable i thought it's worth sharing the code.