- Notifications
You must be signed in to change notification settings - Fork384
Add handling of asyncio coroutines.#162
Add handling of asyncio coroutines.#162apollovy wants to merge 1 commit intopythonprofilers:masterfrom
Conversation
astrojuanlu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi! We just made some infrastructure changes that conflict with your PR. Would you mind rebasing and trying again? Also, adding some tests would be nice :)
| from distutils.core import setup | ||
| import setuptools | ||
| import memory_profiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The method to extract the version was changed.
| license='BSD' | ||
| license='BSD', | ||
| install_requires=['asyncio>=3.4.3'] if sys.version_info < (3, 4) else [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about using PEP 426 markers instead?https://blog.ionelmc.ro/presentations/packaging/#slide:25
OleksaVasylenko commentedSep 21, 2018
@apollovy Hi! Are you going to finish that? That would be a great benefit. |
apollovy commentedSep 21, 2018 via email
Hi. I believe not in the nearest future at least: no time or any plansabout it. It just works for me, so I'm using it from my fork and that's it.пт, 21 сент. 2018 г., 14:12 Oleksa Vasylenko <notifications@github.com>: …@apollovy <https://github.com/apollovy> Hi! Are you going to finish that? That would be a great benefit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABmCLyL6lszyFJWj6pMPYwqKCb1Sfn1xks5udMmLgaJpZM4PpAME> . |
astrojuanlu commentedSep 27, 2018
@OleksaVasylenko if you want to take over, you could do like this on a local memory_profiler checkout: and we can continue the review from there. Thanks! |
Hi.
This patch works for current versions of python, but breaks <3.3 where
yield fromis a syntax error and returning from generatior is not allowed.I will just leave it here in case somebody would want to use this project in async world.
By now I don't see an easy way to deal with the situation except that making a dependency from tornado in 2.7 (and maybe 2.6) and use their machinery for coroutines. But by now I doubt it's worth spending a time on it 🤗
Fixes#161