- Notifications
You must be signed in to change notification settings - Fork384
replace deprecated optparse with argparse#128
Merged
astrojuanlu merged 1 commit intopythonprofilers:masterfromNov 2, 2017
skwbc:argparse
Merged
replace deprecated optparse with argparse#128astrojuanlu merged 1 commit intopythonprofilers:masterfromskwbc:argparse
astrojuanlu merged 1 commit intopythonprofilers:masterfrom
skwbc:argparse
Conversation
Collaborator
astrojuanlu commentedOct 25, 2017
This PR now has conflicts, would you mind rebasing to check that everything is correct? |
ContributorAuthor
skwbc commentedOct 29, 2017
@Juanlu001 |
Collaborator
astrojuanlu commentedNov 2, 2017
Thanks a lot@skwbc! The code looks good and all tests passed, so I think this is good to go. Merging! |
Collaborator
fabianp commentedNov 2, 2017
great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to pull request#2 and#5. These pull requests were created in May 2012.
Now it is November 2016, I think that Python 2.6 and 3.1 are rarely used.
What is your idea?