- Notifications
You must be signed in to change notification settings - Fork14
Small fixes while reviewing the document#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
filmor left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Themono executable is lowercase. Also it is not strictly necessary to use mono like this (binfmt_misc), I'd just drop that addition.
den-run-ai commentedFeb 20, 2017
Good catch, TIL about binfmt_misc. However it likely requires registration like on Windows. Here is a quick test: |
readme.html Outdated
| <li><ahref="#arrays">Using Arrays</a></li> | ||
| <li><ahref="#collections">Using Collections</a></li> | ||
| <li><ahref="#com">COMComponents</a></li> | ||
| <li><ahref="#com">COMComponefnts</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yep
readme.html Outdated
| try: | ||
| raise NullReferenceException("aiieee!") | ||
| except NullReferenceException, e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
except NullReferenceException as e: for it to be PY3 compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this one is outside of what you were fixing. Just noticed it while reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good catch
vmuriart left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. Ok tosquash-merge
den-run-ai commentedFeb 22, 2017
@vmuriart should we defer updating PythonNet to pythonnet? |
vmuriart commentedFeb 22, 2017
I didn't see it as part of these changes. Let's not add them yet till we come closer to a decision. |
den-run-ai commentedFeb 22, 2017
@filmor do you agree with merging this? |
Uh oh!
There was an error while loading.Please reload this page.
npython, print(), py36, typo, links, simplified API