Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jun 9, 2020. It is now read-only.

Update mono repo locations + Add python 3.6 support#5

Open
zteisberg wants to merge2 commits intopythonnet:master
base:master
Choose a base branch
Loading
fromzteisberg:zteisberg/python3.6

Conversation

zteisberg
Copy link
Collaborator

@zteisbergzteisberg commentedNov 14, 2017
edited by vmuriart
Loading

Edit:
To give context about change of mono repo location

I ran into an error building a docker image from the dockerfile. It indicated that '4.8.0.520-0xamarin3' for 'mono-complete' was not found. I changed it to point the Ubuntu snapshot for 4.8.0.520 and it worked. --@fdanny#6

chrisjbremner, zymergen-jonas, michaelosthege, and den-run-ai reacted with thumbs up emoji
@chrisjbremner
Copy link

@vmuriart@cowboygneox I noticed you weren't tagged on this, but have reviewed PRs in the past. Thought I would bump this PR since it would be useful for me too.

@vmuriart
Copy link
Contributor

Looks good to me, though I wish it would build.
@denfromufa any idea why our build is failing with invalid credentials?

@den-run-ai
Copy link
Contributor

den-run-ai commentedDec 21, 2017
edited
Loading

@vmuriart@chrisjbremner@zteisberg looks like travis allows this kind of builds only for repo owners, here is a similar issue:

appium/appium-docker-android#34

@den-run-ai
Copy link
Contributor

@zteisberg i added you as collaborator to test out the hypothesis about travis permissions

@den-run-ai
Copy link
Contributor

@zteisberg can you send me your email for docker account to be added to pythonnet? my email is in my github profile.

@cowboygneox
Copy link

cowboygneox commentedDec 26, 2017
edited
Loading

@zteisberg I'm confused as to why you're pointing at a mono snapshot and not updating the mono version?

Looks fine otherwise.

@vmuriart
Copy link
Contributor

@cowboygneox I think the details from#6 answer the question.

I ran into an error building a docker image from the dockerfile. It indicated that '4.8.0.520-0xamarin3' for 'mono-complete' was not found. I changed it to point the Ubuntu snapshot for 4.8.0.520 and it worked.

@vmuriart
Copy link
Contributor

@denfromufaThis is probably the reason why our builds are failing. I remember seeing that on my feeds a while back, but didn't think much of it till just now.

Though I've looked into it a bit more, and it seems we are following all the recommendations. I tried building directly (non-PR) and fails to authenticate as well.

I wonder if we need to re-setup the secure ENV and then try again...

Leaving these resources here to look into later:
https://medium.com/mobileforgood/coding-tips-patterns-for-continuous-integration-with-docker-on-travis-ci-9cedb8348a62

https://docs.travis-ci.com/user/docker/#Pushing-a-Docker-Image-to-a-Registry

@vmuriartvmuriart requested review fromvmuriart and removed request forvmuriartDecember 27, 2017 05:55
@vmuriart
Copy link
Contributor

The docker-build/authentication is a separate issue from what this PR is trying to do.
Just looking at the changes I'm ok with merging without waiting to resolve the Travis build.

Any objections to merge this in? Sounded like@cowboygneox was ok with the changes as well.

@den-run-ai
Copy link
Contributor

@vmuriart who will push the actual built docker containers to docker hub? I'm getting authentication errors even on my local machine.

@vmuriart
Copy link
Contributor

@denfromufa good point. I'll give it a try when I get home

@vmuriart
Copy link
Contributor

The docker install on my machine is broken. Couldn't tests locally.

@jonemo
Copy link
Collaborator

@zteisberg I'm confused as to why you're pointing at a mono snapshot and not updating the mono version?

@cowboygneox: I'm not@zteisberg, but I suspect he did this because if you don't pin to the specific version4.8.0.520, the commandapt-get install -y mono-complete=4.8.0.520-0xamarin3 further below in the file will fail.

The docker install on my machine is broken. Couldn't tests locally.

@vmuriart: I ran this command using Docker for Mac version 17.09.1 (latest from the stable channel) and it built the image and exited without error:

docker build -t pythonnet/pythonnet:python3.6-mono4.8.0-pythonnet2.3.0 -f Dockerfile-python3.6-mono4.8.0-pythonnet2.3.0 .
chrisjbremner reacted with thumbs up emoji

@jonemo
Copy link
Collaborator

For anyone else who finds this issue while searching for a Pythonnet Docker image with Python 3.6: To cover the time until the CI workflow in this repo is fixed, I have created a repo with a wider range of Python and Mono versions here, including Python 3.6:

I'd be happy to contribute these back to this repo here if that's of interest to the maintainers, and/or would appreciate feedback and contributions over inhttps://github.com/jonemo/pythonnet-docker.

@den-run-ai
Copy link
Contributor

@jonemo would you like to try and push this to main pythonnet docker repo? if yes, send me your email address.

@den-run-ai
Copy link
Contributor

@jonemo I added you to both pythonnet-docker and github-pythonnet-docker collaborators. Feel free to push your updates directly there.

@cowboygneox
Copy link

I was added as a collaborator here. Is that a request for me to jump in?

@den-run-ai
Copy link
Contributor

den-run-ai commentedJun 12, 2018 via email

Sean,I added the same permissions for 3 people on both dockerhub andgithub-pythonnet-docker.If you would like to take a look at the problem, that is encouraged :)In 2-3 weeks@jonemo may jump in to sync his docker pythonnet channel withthis official channel.
On Tue, Jun 12, 2018, 6:31 AM Sean Freitag ***@***.***> wrote: I was added as a collaborator here. Is that a request for me to jump in? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgZ5RaKLhgTftYwvzHumfKXffEmUZ5Yks5t76Z8gaJpZM4Qd7sn> .

@michaelosthege
Copy link

Hello,
I'm trying to create a Dockerfile that buildsFROM continuumio/miniconda3 and uses Python 3.6. I tried to adopt theDockerfile-python3.6-mono4.8.0-pythonnet2.3.0 from this PR, but thepip installation fails. I think this is the relevant portion of the error log:

Failed building wheel for pythonnet  Running setup.py clean for pythonnetFailed to build pythonnetInstalling collected packages: pythonnet  Running setup.py install for pythonnet: started    Running setup.py install for pythonnet: finished with status 'error'    Complete output from command /opt/conda/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-11w71mh7/pythonnet/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-4qjs4_he/install-record.txt --single-version-externally-managed --compile:    running install    running build    running build_ext    Checking for updates from https://www.nuget.org/api/v2/.    Currently running NuGet.exe 4.7.1.    NuGet.exe is up to date.    MSBuild auto-detection: using msbuild version '14.0' from '/usr/lib/mono/xbuild/14.0/bin'.    MSBUILD: error MSBUILD0004: Too many project files specified    WARNING: Error reading msbuild project information, ensure that your input solution or project file is valid. NETCore and UAP projects will be skipped, only packages.config files will be restored.    All packages listed in packages.config are already installed.

I also tried to run it exactly as it is in this PR, but it fails with the same error.
Could this have something to do with a recent change to the main repo?

@den-run-ai
Copy link
Contributor

@michaelosthege you can probably check in the mono gitter channel first about this weird error "Too many project files specified"

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@zteisberg@chrisjbremner@vmuriart@den-run-ai@cowboygneox@jonemo@michaelosthege

[8]ページ先頭

©2009-2025 Movatter.jp