- Notifications
You must be signed in to change notification settings - Fork750
Add C# Dictionary to Python Dict conversion#972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedOct 18, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #972 +/- ##======================================= Coverage 86.71% 86.71% ======================================= Files 1 1 Lines 301 301 ======================================= Hits 261 261 Misses 40 40
Continue to review full report at Codecov.
|
Thanks a lot for this. However, as noted in#963, I'd really like to get away from the implicit conversions and instead allow the wrapped C# object toact like a Python |
Oh thats nice :) Will it take long until the implicit conversions get replaced? Because maybe this PR could still be a temporary solution to allow the use of In#963 you only mention |
What does this implement/fix? Explain your changes.
You can now convert a C# IDictionary to a Python Dict by calling ToPython()
Does this close any currently open issues?
No, but it is progress for#623
Any other comments?
Do i really have to include a test for this? I mean, theTestConverter.cs file doesnt have any tests for other similar types like
IList
at all.Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG