- Notifications
You must be signed in to change notification settings - Fork752
Remove delegate casting#936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…n the NET standard documentation for GetDelegateForFunctionPointer
@filmor I don't believe I can kick the build ... |
@jmlidbetter can you open a bug for the issue you are trying to fix with repro steps? |
@lostmsu You can repro the issue by compiling in dotnet core which I don't believe is officially supported so didnt think an issue is strictly necessary in this case. Check out pr 550 for more background / precedent on the changes as well as the other things mentioned above :) |
Looks good to me. |
…n the NET standard documentation for GetDelegateForFunctionPointer (pythonnet#936)
What does this implement/fix? Explain your changes.
Fixes an issue where pythonnet attempts to cast one managed delegate to another. This is explicitly forbidden in the documentation:see here. In particular:
I have also removed the usage of the obselete function GetDelegateForFunctionPointer(IntPtr, Type) and replaced it with GetDelegateForFunctionPointer<IntPtr).
Does this close any currently open issues?
No
Any other comments?
It seems like this issue got partially fixed in PR#550 and was mentioned in issue#96. See also this relatedissue in dotnet core.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG