- Notifications
You must be signed in to change notification settings - Fork752
Adds support to convert iterators to arrays#928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
0bd4a10
to2e51321
CompareThis looks like a good addition feature-wise, but there is quite a bit of duplicated code in it. I think it would be better if we had /one/ implementation based on the iterator protocol, that just uses an additional size hint if |
Sure. Presumably sequence protocol => iterator protocol? |
It says so in the docs:https://docs.python.org/2/library/stdtypes.html#iterator-types as well ashttps://docs.python.org/3/library/stdtypes.html#iterator-types:
|
Ok, have redone - always uses iterator protocol now. |
@filmor Passed! |
This looks great, thanks :) |
Uh oh!
There was an error while loading.Please reload this page.
What does this implement/fix? Explain your changes.
Python 3 has much more liberal use of iterators, e.g. getting keys or values from a dictionary. This adds functionality to convert python object which support the iterator protocol to arrays in C#.
Does this close any currently open issues?
No
Any other comments?
N/A
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG