Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Removes imports deprecated in Python3#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 2 commits intopythonnet:masterfromCronan:py3_fix
Aug 2, 2019
Merged

Removes imports deprecated in Python3#925

filmor merged 2 commits intopythonnet:masterfromCronan:py3_fix
Aug 2, 2019

Conversation

Cronan
Copy link
Contributor

What does this implement/fix? Explain your changes.

A small number of existing imports are deprecated in Python3.
This removes them or compiles them out.

Does this close any currently open issues?

Fixes#924
...

Any other comments?

N/A

Checklist

Check all those that are applicable and complete.

  • [N/A] Make sure to include one or more tests for your change
  • [N/A] If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@CronanCronan marked this pull request as ready for reviewJuly 30, 2019 15:09
@Cronan
Copy link
ContributorAuthor

@filmor Any idea why the build is broken?

@filmor
Copy link
Member

The Appveyor build just timed out for one part, I triggered it again and it seems to work fine now. The Travis build looks a bit trickier, the Mono version pulled in seems to be broken...

@filmor
Copy link
Member

Meh, the travis error is broken. The symbol it is missing is_ZTIPi which is the C++ type info forint*, so maybe there are incompatible C++ ABIs at play here ...

@Cronan
Copy link
ContributorAuthor

How can the build just break? Were there changes made?

@filmor
Copy link
Member

The mono version is not pinned right now, so since the 18th we pull in mono 6. I'll see whether I can lock us to 5.20 for now.

@Cronan
Copy link
ContributorAuthor

Cronan commentedAug 1, 2019 via email

Good spot, thank you
…
On 1 Aug 2019, at 09:05, Benedikt Reinartz ***@***.***> wrote: The mono version is not pinned right now, so since the 18th we pull in mono 6. I'll see whether I can lock us to 5.20 for now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

@codecov-io
Copy link

codecov-io commentedAug 1, 2019•
edited
Loading

Codecov Report

Merging#925 intomaster willincrease coverage by1.76%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #925      +/-   ##==========================================+ Coverage   74.48%   76.25%   +1.76%==========================================  Files          62       65       +3       Lines        5902     6030     +128       Branches      967      990      +23     ==========================================+ Hits         4396     4598     +202+ Misses       1153     1099      -54+ Partials      353      333      -20
FlagCoverage Δ
#setup_linux65.44% <ø> (ø)⬆️
#setup_windows75.48% <ø> (+1.97%)⬆️
Impacted FilesCoverage Δ
src/runtime/runtime.cs86.95% <ø> (+0.01%)⬆️
src/runtime/interop.cs95.73% <0%> (-0.49%)⬇️
src/runtime/interop35.cs100% <0%> (ø)
src/runtime/interop37.cs100% <0%> (ø)
src/runtime/interop36.cs100% <0%> (ø)
src/runtime/typemanager.cs83.64% <0%> (+0.25%)⬆️
src/runtime/moduleobject.cs81.31% <0%> (+0.54%)⬆️
src/runtime/exceptions.cs79.13% <0%> (+1.45%)⬆️
src/runtime/assemblymanager.cs87.03% <0%> (+1.85%)⬆️
... and7 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6f635a4...f6a9954. Read thecomment docs.

@Cronan
Copy link
ContributorAuthor

@filmor Can be merged?

@filmor
Copy link
Member

Yeah, looks good to me.@lostmsu Be aware of this one if you are looking into switching to delegates.

@filmorfilmor merged commit1ce630e intopythonnet:masterAug 2, 2019
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull requestJun 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python2 deprecated native method import
3 participants
@Cronan@filmor@codecov-io
[8]ページ先頭
©2009-2025 Movatter.jp