- Notifications
You must be signed in to change notification settings - Fork750
allow .NET classes to override __getattr__ and __setattr__#901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes fromall commits
Commits
Show all changes
3 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletionsCHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletionssrc/embed_tests/Python.EmbeddingTest.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletionssrc/embed_tests/TestInstanceWrapping.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| using NUnit.Framework; | ||
| using Python.Runtime; | ||
| using Python.Runtime.Slots; | ||
| namespace Python.EmbeddingTest { | ||
| public class TestInstanceWrapping { | ||
| [Test] | ||
| public void GetAttrCanBeOverriden() { | ||
| var overloaded = new Overloaded(); | ||
| using (Py.GIL()) { | ||
| var o = overloaded.ToPython(); | ||
| dynamic getNonexistingAttr = PythonEngine.Eval("lambda o: o.non_existing_attr"); | ||
| string nonexistentAttrValue = getNonexistingAttr(o); | ||
| Assert.AreEqual(GetAttrFallbackValue, nonexistentAttrValue); | ||
| } | ||
| } | ||
| [Test] | ||
| public void SetAttrCanBeOverriden() { | ||
| var overloaded = new Overloaded(); | ||
| using (Py.GIL()) | ||
| using (var scope = Py.CreateScope()) { | ||
| var o = overloaded.ToPython(); | ||
| scope.Set(nameof(o), o); | ||
| scope.Exec($"{nameof(o)}.non_existing_attr = 42"); | ||
| Assert.AreEqual(42, overloaded.Value); | ||
| } | ||
| } | ||
| const string GetAttrFallbackValue = "undefined"; | ||
| class Base {} | ||
| class Derived: Base { } | ||
| class Overloaded: Derived, IGetAttr, ISetAttr | ||
| { | ||
| public int Value { get; private set; } | ||
| public bool TryGetAttr(string name, out PyObject value) { | ||
| value = GetAttrFallbackValue.ToPython(); | ||
| return true; | ||
| } | ||
| public bool TrySetAttr(string name, PyObject value) { | ||
| this.Value = value.As<int>(); | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| } |
27 changes: 14 additions & 13 deletionssrc/runtime/Python.Runtime.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
10 changes: 9 additions & 1 deletionsrc/runtime/runtime.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletionssrc/runtime/slots.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| using System; | ||
| namespace Python.Runtime.Slots | ||
| { | ||
| /// <summary> | ||
| /// Implement this interface to override Python's __getattr__ for your class | ||
| /// </summary> | ||
| public interface IGetAttr { | ||
| bool TryGetAttr(string name, out PyObject value); | ||
| } | ||
| /// <summary> | ||
| /// Implement this interface to override Python's __setattr__ for your class | ||
| /// </summary> | ||
| public interface ISetAttr { | ||
| bool TrySetAttr(string name, PyObject value); | ||
| } | ||
| static class SlotOverrides { | ||
| public static IntPtr tp_getattro(IntPtr ob, IntPtr key) { | ||
| IntPtr genericResult = Runtime.PyObject_GenericGetAttr(ob, key); | ||
| if (genericResult != IntPtr.Zero || !Runtime.PyString_Check(key)) { | ||
| return genericResult; | ||
| } | ||
| Exceptions.Clear(); | ||
| var self = (IGetAttr)((CLRObject)ManagedType.GetManagedObject(ob)).inst; | ||
| string attr = Runtime.GetManagedString(key); | ||
| return self.TryGetAttr(attr, out var value) | ||
| ? Runtime.SelfIncRef(value.Handle) | ||
| : Runtime.PyObject_GenericGetAttr(ob, key); | ||
| } | ||
| public static int tp_setattro(IntPtr ob, IntPtr key, IntPtr val) { | ||
| if (!Runtime.PyString_Check(key)) { | ||
| return Runtime.PyObject_GenericSetAttr(ob, key, val); | ||
| } | ||
| var self = (ISetAttr)((CLRObject)ManagedType.GetManagedObject(ob)).inst; | ||
| string attr = Runtime.GetManagedString(key); | ||
| return self.TrySetAttr(attr, new PyObject(Runtime.SelfIncRef(val))) | ||
| ? 0 | ||
| : Runtime.PyObject_GenericSetAttr(ob, key, val); | ||
| } | ||
| } | ||
| } |
15 changes: 14 additions & 1 deletionsrc/runtime/typemanager.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.