NotificationsYou must be signed in to change notification settings
Fork750
Star5.1k

Minimal Py_IntializeEx change#777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

filmor merged 3 commits intopythonnet:masterfromfilmor:minimal-initializeex

Nov 15, 2018

Merged

Minimal Py_IntializeEx change#777

filmor merged 3 commits intopythonnet:masterfromfilmor:minimal-initializeex

Nov 15, 2018

Conversation

Copy link

Member

filmor commentedNov 15, 2018

What does this implement/fix? Explain your changes.

Minimal version of#724, allows the user to select whether an embedded Python should configure signal handlers or not, defaulting to "false" (which is different from what we had before as a straight call toPy_Initialize will configure signal handlers).

Does this close any currently open issues?

Fixes#449.

Any other comments?

We should follow up on#724 to get a unit test working for this, but this can wait until after 2.4.0.

Copy link

codecovbot commentedNov 15, 2018•
edited
Loading

Codecov Report

Merging#777 intomaster willdecrease coverage by13.44%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master    #777       +/-   ##==========================================- Coverage   77.04%   63.6%   -13.45%==========================================  Files          63       1       -62       Lines        5786     283     -5503       Branches      911       0      -911     ==========================================- Hits         4458     180     -4278+ Misses       1024     103      -921+ Partials      304       0      -304

Flag	Coverage Δ
#setup_linux	`63.6% <ø> (-4.95%)`	⬇️
#setup_windows	`?`

Impacted Files	Coverage Δ
setup.py	`63.6% <0%> (-22.62%)`	⬇️
src/runtime/pyansistring.cs
src/runtime/constructorbinder.cs
src/runtime/methodbinder.cs
src/runtime/Util.cs
src/runtime/delegatemanager.cs
src/runtime/eventbinding.cs
src/runtime/pyiter.cs
src/runtime/pynumber.cs
src/runtime/interop27.cs
... and51 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update5c9f035...62634f9. Read thecomment docs.