NotificationsYou must be signed in to change notification settings
Fork749
Star5.1k

Reset gchead and refchain after shutdown#754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

amos402 wants to merge3 commits intopythonnet:masterfromamos402:reset-gc

Closed

Reset gchead and refchain after shutdown#754

amos402 wants to merge3 commits intopythonnet:masterfromamos402:reset-gc

Conversation

Copy link

Member

amos402 commentedOct 18, 2018

What does this implement/fix? Explain your changes.

...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself toAUTHORS
Updated theCHANGELOG

Reset gchead and refchain after shutdown

1fae108

amos402 mentioned this pull request

Oct 18, 2018

Enable pythonnet to survive in the Unity3d editor environment.#752

Merged

filmor added the WIP label

Oct 18, 2018

Merge branch 'master' into reset-gc

6849df3

Copy link

codecovbot commentedMar 6, 2019

Codecov Report

Merging#754 intomaster willincrease coverage by2%.
The diff coverage is100%.

@@           Coverage Diff           @@##           master     #754   +/-   ##=======================================+ Coverage   75.06%   77.06%   +2%=======================================  Files          60       62    +2       Lines        5658     5617   -41       Branches      920      899   -21     =======================================+ Hits         4247     4329   +82+ Misses       1078      994   -84+ Partials      333      294   -39

Flag	Coverage Δ
#setup_linux	`62.94% <ø> (-5.61%)`	⬇️
#setup_windows	`76.44% <100%> (+2.39%)`	⬆️

Impacted Files	Coverage Δ
src/runtime/runtime.cs	`91.43% <100%> (+4.75%)`	⬆️
src/runtime/pythonengine.cs	`80.08% <100%> (+2.02%)`	⬆️
src/runtime/extensiontype.cs	`74.07% <0%> (-5.1%)`	⬇️
src/runtime/pyscope.cs	`57.71% <0%> (-0.71%)`	⬇️
src/runtime/pyobject.cs	`39.77% <0%> (-0.57%)`	⬇️
src/runtime/interop.cs	`95.73% <0%> (-0.49%)`	⬇️
src/runtime/classbase.cs	`80.95% <0%> (-0.43%)`	⬇️
src/runtime/classderived.cs	`88.34% <0%> (-0.08%)`	⬇️
src/runtime/classmanager.cs	`94.83% <0%> (-0.07%)`	⬇️
... and16 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update93a8c83...6849df3. Read thecomment docs.