Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix travis, work around appveyor build breaks#751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

benoithudson
Copy link
Contributor

Continuous integration on pythonnet/master is broken at the moment. This patch gets to green-light on master.

(1) Travis now has msbuild 15 available, which breaks the no-arg build since it's using the pythonnet.sln which is msbuild 14. Fixed by forcing the use of msbuild 14.

(2) Appveyor on py34 is failing to build psutil. Newer python and py27 are using binary releases so the problem doesn't show up. I couldn't figure out how to fix it, so I made it an allowed failure.

Travis now has msbuild 15 available, which breaks the no-arg build since it's using the pythonnet.sln which is msbuild 14. Fixed by forcing the use of msbuild 14.Appveyor on py34 is failing to build psutil; newer python and py27 are using binary releases so the problem doesn't show up. I couldn't figure out how to fix it, so I made it an allowed failure.
@codecov
Copy link

codecovbot commentedOct 12, 2018
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b6417ca).Click here to learn what that means.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff            @@##             master     #751   +/-   ##=========================================  Coverage          ?   77.21%           =========================================  Files             ?       62             Lines             ?     5583             Branches          ?      891           =========================================  Hits              ?     4311             Misses            ?      980             Partials          ?      292
FlagCoverage Δ
#setup_linux69.42% <100%> (?)
#setup_windows76.39% <100%> (?)
Impacted FilesCoverage Δ
setup.py87.41% <100%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb6417ca...3625286. Read thecomment docs.

@benoithudson
Copy link
ContributorAuthor

@filmor, @denfromufa -- this patch is ready for merge, and then I can squash#745.

@filmorfilmor merged commit8a9fd73 intopythonnet:masterOct 12, 2018
@filmor
Copy link
Member

There you go, thank you very much :)

@den-run-ai
Copy link
Contributor

i approve this!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@benoithudson@filmor@den-run-ai

[8]ページ先頭

©2009-2025 Movatter.jp