Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix memory leaks due to spurious handle increment and add unit tests#704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 6 commits intopythonnet:masterfromwilliamsardar:master
Jul 23, 2018

Conversation

williamsardar
Copy link
Contributor

@williamsardarwilliamsardar commentedJul 20, 2018
edited by filmor
Loading

What does this implement/fix? Explain your changes.

Fix memory leaks due to spurious handle increment and add unit tests
...

Does this close any currently open issues?

Issue#691
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • [ x ] Make sure to include one or more tests for your change
  • [ x ] If an enhancement PR, please create docs and at best an example
  • [ x ] Add yourself toAUTHORS
  • [ x ] Updated theCHANGELOG

jaredbroad and filmor reacted with hooray emoji
@codecov
Copy link

codecovbot commentedJul 20, 2018
edited
Loading

Codecov Report

Merging#704 intomaster willincrease coverage by0.45%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff            @@##           master    #704      +/-   ##=========================================+ Coverage   76.94%   77.4%   +0.45%=========================================  Files          63      63                Lines        5592    5589       -3       Branches      892     892              =========================================+ Hits         4303    4326      +23+ Misses        998     970      -28- Partials      291     293       +2
FlagCoverage Δ
#setup_linux69.42% <ø> (ø)⬆️
#setup_windows76.57% <100%> (+0.45%)⬆️
Impacted FilesCoverage Δ
src/runtime/overload.cs73.91% <ø> (+15.57%)⬆️
src/runtime/methodbinding.cs79.59% <ø> (-0.41%)⬇️
src/runtime/constructorbinding.cs39.43% <100%> (+29.57%)⬆️
src/runtime/runtime.cs91.37% <0%> (+0.39%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update611814c...a97a776. Read thecomment docs.

@filmor
Copy link
Member

There are probably more issues like this in the code, essentially every class derived fromExtensionType does not need an additionalIncref as far as I can see, since thePyType_GenericAlloc call in the constructor will already lead to a refcount of 1.

@filmorfilmor merged commitfb84cd2 intopythonnet:masterJul 23, 2018
@filmor
Copy link
Member

Thank you very much for your contribution :)

williamsardar reacted with thumbs up emoji

@williamsardar
Copy link
ContributorAuthor

@filmor thanks for the merge. Any indication as to when the next release might happen?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@williamsardar@filmor

[8]ページ先頭

©2009-2025 Movatter.jp