Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update moduleobject.cs#655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
den-run-ai merged 2 commits intopythonnet:masterfromicetiger1974:patch-1
Jun 12, 2018
Merged

Conversation

icetiger1974
Copy link
Contributor

I am a novice in English and pythonnet.
But I am a Fan of pythonnet.

The Proposed file is about NTFS Security.
https://stackoverflow.com/questions/4496697/what-is-zone-identifier

please check~

What does this implement/fix? Explain your changes.

... In case of Windows 10, We can find the DLL with Blocking.
.. But current code provides wrong information. So I modified these code lines

Does this close any currently open issues?

... I can not find open issues

Any other comments?

... none

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

I am a novice in English and pythonnet.But I am a Fan of pythonnet.The Proposed file is about NTFS Security.https://stackoverflow.com/questions/4496697/what-is-zone-identifierplease check~
@den-run-ai
Copy link
Contributor

@icetiger1974 this seems legitimate, what kind of error does pythonnet show without this fix for these "unsecure" dlls?

@den-run-ai
Copy link
Contributor

@icetiger1974 appveyor tests failing, weird.

@icetiger1974
Copy link
ContributorAuthor

Hi, denfromufa.
Thank you for response

The exact error message to me was “FileNotFoundException: Unable to find assembly 'C:\DLL\myDLL.dll'.”

@codecov
Copy link

codecovbot commentedMay 28, 2018•
edited
Loading

Codecov Report

Merging#655 intomaster willdecrease coverage by0.05%.
The diff coverage is0%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #655      +/-   ##==========================================- Coverage   76.89%   76.83%   -0.06%==========================================  Files          64       64                Lines        5583     5587       +4       Branches      889      891       +2     ==========================================  Hits         4293     4293- Misses       1000     1003       +3- Partials      290      291       +1
FlagCoverage Δ
#setup_linux69.42% <ø> (ø)⬆️
#setup_windows76.01% <0%> (-0.06%)⬇️
Impacted FilesCoverage Δ
src/runtime/moduleobject.cs83.14% <0%> (-1.92%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef0f6b6b...f0c5f62. Read thecomment docs.

@den-run-aiden-run-ai merged commitd27ab61 intopythonnet:masterJun 12, 2018
@den-run-ai
Copy link
Contributor

@icetiger1974 merged, thanks!

@icetiger1974
Copy link
ContributorAuthor

Hi denfromufa
Thank you very much.
Best regards
icetiger1974

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@icetiger1974@den-run-ai@filmor
[8]ページ先頭
©2009-2025 Movatter.jp