Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added inline comment about dangers of multidomain usage#625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 2 commits intopythonnet:featuredfromJanKrivanek:patch-2
Oct 16, 2018

Conversation

JanKrivanek
Copy link
Contributor

@JanKrivanekJanKrivanek commentedFeb 12, 2018•
edited
Loading

As requested here:#538 (comment)

What does this implement/fix? Explain your changes.

Just a commnet

Does this close any currently open issues?

No. But comment was requested

Any other comments?

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@den-run-ai
Copy link
Contributor

@jakrivan please update the changelog and add yourself to authors.

JanKrivanek added a commit to JanKrivanek/pythonnet that referenced this pull requestJun 12, 2018
JanKrivanek added a commit to JanKrivanek/pythonnet that referenced this pull requestJun 12, 2018
JanKrivanek added a commit to JanKrivanek/pythonnet that referenced this pull requestJun 12, 2018
@codecov
Copy link

codecovbot commentedJun 12, 2018

Codecov Report

Merging#625 intofeatured willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff            @@##           featured    #625   +/-   ##========================================  Coverage      76.6%   76.6%           ========================================  Files            71      71             Lines          6023    6023             Branches        961     961           ========================================  Hits           4614    4614             Misses         1080    1080             Partials        329     329
FlagCoverage Δ
#setup_linux69.42% <ø> (ø)⬆️
#setup_windows75.84% <ø> (ø)⬆️
Impacted FilesCoverage Δ
src/runtime/assemblymanager.cs87.37% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update6488c2a...9255b6b. Read thecomment docs.

@JanKrivanek
Copy link
ContributorAuthor

@denfromufa Thanks. Done

@filmorfilmor merged commit0b9e6a1 intopythonnet:featuredOct 16, 2018
@filmor
Copy link
Member

Argh, didn't notice that this was against the "featured" branch. I'll cherry pick it on master...

@den-run-ai
Copy link
Contributor

@filmor would you like to revert this PR from featured branch managed by@dmitriyse ?

@filmor
Copy link
Member

Not particularly, no. This is just an additional comment and the featured branch (as essentially a fork) shouldn't exist in the first place.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JanKrivanek@den-run-ai@filmor
[8]ページ先頭
©2009-2025 Movatter.jp