NotificationsYou must be signed in to change notification settings
Fork752
Star5.1k

PyObject was made IEnumerable#596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

den-run-ai merged 1 commit intopythonnet:masterfromdmitriyse:pyobject-ienumerable

Feb 10, 2018

Merged

PyObject was made IEnumerable#596

den-run-ai merged 1 commit intopythonnet:masterfromdmitriyse:pyobject-ienumerable

Feb 10, 2018

Conversation

Copy link

Contributor

dmitriyse commentedJan 12, 2018•
edited
Loading

What does this implement/fix? Explain your changes.

enumerable python object cannot be directly enumerated through PyObject.

dynamicpyCollectionObj=newPyObject(collectionObjIntPtr);foreach(dynamiciteminpyCollectionObj){// This code currently does not works.}...### Does this close any currently openissues?No...### Any othercomments?Tests are failed due to NUnit Assert.Equals behavior. Whenobjectis IEnumerable Assert.Equals also compares all items....### ChecklistCheck all those that areapplicable andcomplete.-[]Makesure to include one or more testsfor your change-[]Ifan enhancement PR,pleasecreate docs and at best an example-[]Addyourself to[`AUTHORS`](../blob/master/AUTHORS.md)-[]Updatedthe[`CHANGELOG`](../blob/master/CHANGELOG.md)

PyObject was made IEnumerable

27da1ca

dmitriyse requested review fromfilmor,den-run-ai andvmuriart

January 12, 2018 23:02

den-run-ai approved these changes

Feb 10, 2018

View reviewed changes

den-run-ai merged commitb8cb6c4 intopythonnet:master

Feb 10, 2018

Copy link

Contributor

den-run-ai commentedFeb 10, 2018

So weird, this pull request caused master to fail consistently in Travis CI on Python 3.5:

https://travis-ci.org/pythonnet/pythonnet/jobs/339756543#L2103

1) Failed : Python.EmbeddingTest.TestExample.TestReadme  Expected string length 16 but was 13. Strings differ at index 2.  Expected: "[  6.  10.  12.]"  But was:  "[ 6. 10. 12.]"  -------------^at (wrapper dynamic-method) System.Object.CallSite.Target(System.Runtime.CompilerServices.Closure,System.Runtime.CompilerServices.CallSite,System.Type,string,object)at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid3[T0,T1,T2] (System.Runtime.CompilerServices.CallSite site, T0 arg0, T1 arg1, T2 arg2) [0x00110] in <b0fca80f08474611b248e2d30bb75230>:0at Python.EmbeddingTest.TestExample.TestReadme () [0x00958] in <ee790b8ab98547918ddc44014a1093cd>:0