Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Marshalling fix for 3-IntPtr args cdecl calls.#550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dmitriyse merged 1 commit intopythonnet:masterfromdmitriyse:core2-marshal-fix
Dec 12, 2017

Conversation

dmitriyse
Copy link
Contributor

What does this implement/fix? Explain your changes.

Workaround for the DotNet Core 2.0 marshaling bug.
Problem described here#96 (comment)
...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@codecov
Copy link

codecovbot commentedOct 3, 2017
edited
Loading

Codecov Report

Merging#550 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #550   +/-   ##=======================================  Coverage   77.14%   77.14%           =======================================  Files          65       65             Lines        5617     5617             Branches      888      888           =======================================  Hits         4333     4333             Misses        996      996             Partials      288      288
FlagCoverage Δ
#setup_linux71.83% <ø> (ø)⬆️
#setup_windows76.28% <ø> (ø)⬆️
Impacted FilesCoverage Δ
src/runtime/nativecall.cs100% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef5a002f...580f13f. Read thecomment docs.

@dmitriyse
Copy link
ContributorAuthor

Related CoreCLR bug described herehttps://github.com/dotnet/coreclr/issues/14362

@dmitriyse
Copy link
ContributorAuthor

It's a hot fix. That not fully solve the problem.
I created issue for the full solution#553

@den-run-ai
Copy link
Contributor

@dmitriyse is there any test for this "fix" or can you describe what issue you experienced? thanks for digging this through. also for the full potential fix in the future can you also describe a failing test?
finally this does not look like a bug in .net core, since this marshalling works as described in documentation.

@den-run-ai
Copy link
Contributor

@dmitriyse I just noticed that this fixed the issue that I experienced here:#96 (comment)

let me verify it quickly.

@den-run-ai
Copy link
Contributor

@dmitriyse your fix is verified.

@den-run-ai
Copy link
Contributor

@filmor@vmuriart please review, I think this is good to go!

@dmitriysedmitriyse merged commit46d56af intopythonnet:masterDec 12, 2017
@dmitriysedmitriyse deleted the core2-marshal-fix branchDecember 12, 2017 23:57
@jmlidbetterjmlidbetter mentioned this pull requestAug 7, 2019
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@den-run-aiden-run-aiden-run-ai approved these changes

@filmorfilmorAwaiting requested review from filmor

@tonyrobertstonyrobertsAwaiting requested review from tonyroberts

@vmuriartvmuriartAwaiting requested review from vmuriart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dmitriyse@den-run-ai

[8]ページ先頭

©2009-2025 Movatter.jp