- Notifications
You must be signed in to change notification settings - Fork752
Marshalling fix for 3-IntPtr args cdecl calls.#550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedOct 3, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #550 +/- ##======================================= Coverage 77.14% 77.14% ======================================= Files 65 65 Lines 5617 5617 Branches 888 888 ======================================= Hits 4333 4333 Misses 996 996 Partials 288 288
Continue to review full report at Codecov.
|
Related CoreCLR bug described herehttps://github.com/dotnet/coreclr/issues/14362 |
It's a hot fix. That not fully solve the problem. |
@dmitriyse is there any test for this "fix" or can you describe what issue you experienced? thanks for digging this through. also for the full potential fix in the future can you also describe a failing test? |
@dmitriyse I just noticed that this fixed the issue that I experienced here:#96 (comment) let me verify it quickly. |
@dmitriyse your fix is verified. |
ea77ac2
to580f13f
Compare
What does this implement/fix? Explain your changes.
Workaround for the DotNet Core 2.0 marshaling bug.
Problem described here#96 (comment)
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG