NotificationsYou must be signed in to change notification settings
Fork750
Star5.1k

Build system improvements pack - addressing comments to PR and some issues.#546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

den-run-ai merged 7 commits intopythonnet:masterfromdmitriyse:build-improvements

Nov 7, 2017

Merged

Build system improvements pack - addressing comments to PR and some issues.#546

den-run-ai merged 7 commits intopythonnet:masterfromdmitriyse:build-improvements

Nov 7, 2017

Conversation

Copy link

Contributor

dmitriyse commentedSep 21, 2017

What does this implement/fix? Explain your changes.

Fixes issues specified in reviews for PR#518 and PR#519 and fix for the issue#539

Does this close any currently open issues?

#539
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself toAUTHORS
Updated theCHANGELOG

vswhere.exe tool now distributed with the pythonnet sources, dotnet-c…

55d883b

…ore-2.0-x86 installation step removed.

Copy link

mention-bot commentedSep 21, 2017

@dmitriyse, thanks!@vmuriart,@tonyroberts,@davidanthoff,@tiran and@rickardraysearch, please review this.

Copy link

ContributorAuthor

dmitriyse commentedSep 21, 2017

Please do not review this branch, until I commit and test all part of the solution.
I will notify when this branch will be ready to review and merge.

dmitriyse mentioned this pull request

Sep 21, 2017

CoreCLR msbuild (xplat) support. Initial compilable version.#518

Merged

Copy link

Contributor

den-run-ai commentedSep 21, 2017

@dmitriyse please use [WIP] in your PR title when it is Work In Progress.

.travis.yaml file simplification.

5db8175

Copy link

codecovbot commentedSep 21, 2017•
edited
Loading

Codecov Report

Merging#546 intomaster willdecrease coverage by0.02%.
The diff coverage is71.42%.

@@            Coverage Diff             @@##           master     #546      +/-   ##==========================================- Coverage   77.16%   77.14%   -0.03%==========================================  Files          65       65                Lines        5610     5617       +7       Branches      888      888              ==========================================+ Hits         4329     4333       +4- Misses        993      996       +3  Partials      288      288

Flag	Coverage Δ
#setup_linux	`71.83% <0%> (-1.82%)`	⬇️
#setup_windows	`76.28% <71.42%> (-0.03%)`	⬇️

Impacted Files	Coverage Δ
setup.py	`88.97% <71.42%> (-0.85%)`	⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatedf1c224...0273abf. Read thecomment docs.

den-run-ai changed the title~~Build system improvements pack addressing comments to PR and some issues.~~[WIP] Build system improvements pack addressing comments to PR and some issues.

Sep 21, 2017

PYTHONNET_INTEROP_FILE env var introduced to allow working with custo…

d25696f

…m interop*.cs file inside IDE.

Copy link

ContributorAuthor

dmitriyse commentedSep 21, 2017

Thank you for the tip.

dse added2 commits

September 22, 2017 04:04

pdb generation improved for all conditions Net 4.0/NetStandard 2.0 x …

319dfe4

…Debug/Release.

Fix for thepythonnet#539classic build fails when VS 2017 installed.

f1229bd

dmitriyse force-pushed thebuild-improvements branch 4 times, most recently fromd3c72ad tof1229bdCompare

September 22, 2017 00:30

dmitriyse changed the title~~[WIP] Build system improvements pack addressing comments to PR and some issues.~~Build system improvements pack addressing comments to PR and some issues.

Sep 22, 2017

Copy link

ContributorAuthor

dmitriyse commentedSep 22, 2017

PR is ready !

All comments toCoreCLR msbuild (xplat) support. Initial compilable version. #518 addressed.
DotNet 2.0/ Net4.0 pdb,debug build options for Debug/Release configuration now specified correctly.
(fixes problem when release builds for dotnet core 2.0 generates windows PDB format instead of portable pdb format)
Fix for thelangversion 6 is not recognized with msbuild or csc compiler in VS 2017 #539 issue
PYTHONNET_INTEROP_FILE env var introduced to allow working with custom interop*.cs file inside IDE.
pythonnet.15.sln is tested with Project Rider 2017.1.2 and result is "FULL SUPPORT".
So we should plan when we remove "classic build" or at least make --xplat build as a default.

dmitriyse requested review fromfilmor,tonyroberts,den-run-ai andvmuriart

September 22, 2017 00:41

dmitriyse changed the title~~Build system improvements pack addressing comments to PR and some issues.~~Build system improvements pack - addressing comments to PR and some issues.

Sep 22, 2017

Copy link

ContributorAuthor

dmitriyse commentedSep 22, 2017

It's so good to be a member of the core team, now I can kill broken builds without waiting. :)

filmor approved these changes

Sep 22, 2017

View reviewed changes

dmitriyse mentioned this pull request

Sep 28, 2017

Interop methods with Py_ssize_t works differently in NetCoreApp 2.0#531

Merged

4 tasks

den-run-ai approved these changes

Oct 8, 2017

View reviewed changes

Copy link

Contributor

den-run-ai commentedOct 8, 2017

@dmitriyse i think this is good to merge! if@vmuriart can take a quick look at code coverage failures, that's great, but that is not blocking this PR merge.