Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixed Second PythonEngine.Initialize call, all sensitive static variables now reseted.#534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filmor merged 8 commits intopythonnet:masterfromdmitriyse:valid-engine-reset
Nov 14, 2018

Conversation

@dmitriyse
Copy link
Contributor

@dmitriysedmitriyse commentedAug 31, 2017•
edited by filmor
Loading

What does this implement/fix? Explain your changes.

This change fixes hidden bug. Once python cleaning up enough memory, objects from previous engine run becomes corrupted and produces segfault.
...

Does this close any currently open issues?

It's required but not enough to fix this issue
#499
...

Any other comments?

Described problem never pop up, because ~PyObject currently does not called by the GC (due to some reasons). So many many time pythonnet lives without garbage collection with constant memory leak.
...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS
  • Updated theCHANGELOG

@mention-bot
Copy link

@dmitriyse, thanks!@vmuriart,@tonyroberts,@cgohlke,@tiran and@hsoft, please review this.

@codecov
Copy link

codecovbot commentedAug 31, 2017•
edited
Loading

Codecov Report

Merging#534 intomaster willincrease coverage by8.64%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #534      +/-   ##==========================================+ Coverage   68.55%   77.19%   +8.64%==========================================  Files           1       63      +62       Lines         283     5754    +5471       Branches        0      907     +907     ==========================================+ Hits          194     4442    +4248- Misses         89     1013     +924- Partials        0      299     +299
FlagCoverage Δ
#setup_linux69.42% <ø> (+0.87%)⬆️
#setup_windows76.39% <100%> (?)
Impacted FilesCoverage Δ
src/runtime/pythonengine.cs80.35% <ø> (ø)
src/runtime/moduleobject.cs82.79% <100%> (ø)
src/runtime/runtime.cs88.65% <100%> (ø)
src/runtime/assemblymanager.cs89.17% <100%> (ø)
src/runtime/genericutil.cs86.36% <100%> (ø)
src/runtime/typemanager.cs82.77% <100%> (ø)
src/runtime/classderived.cs88.41% <100%> (ø)
src/runtime/classmanager.cs94.9% <100%> (ø)
src/runtime/pyscope.cs57.92% <100%> (ø)
src/runtime/pyansistring.cs100% <0%> (ø)
... and62 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateaf394ee...dbd5fdd. Read thecomment docs.

CHANGELOG.md Outdated
###Fixed

- Fixed secondary PythonEngine.Initialize call, all sensitive static variables now reseted.
This is a hidden bug. Once python cleaning up enough memory, objects from previous engine run becomes corrupted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please include reference to this PR

@den-run-aiden-run-ai mentioned this pull requestJun 24, 2018
4 tasks
@den-run-ai
Copy link
Contributor

@dmitriyse can you please resolve a conflict in this PR?

@dmitriyse
Copy link
ContributorAuthor

Yes, I will try to do it on this week.

@filmorfilmor added this to the2.4.0 milestoneJul 23, 2018
@filmorfilmor modified the milestone:2.4.0Oct 18, 2018
@filmorfilmor added the next labelOct 18, 2018
@filmor
Copy link
Member

@denfromufa Could you review this again?

@filmorfilmor merged commit88d61a9 intopythonnet:masterNov 14, 2018
@den-run-ai
Copy link
Contributor

@filmor i don't see any obvious issues.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@filmorfilmorfilmor approved these changes

+1 more reviewer

@den-run-aiden-run-aiden-run-ai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dmitriyse@mention-bot@den-run-ai@filmor
[8]ページ先頭
©2009-2026 Movatter.jp