@dmitriyse, thanks!@vmuriart,@tiran,@brianlloyd,@filmor and@tonyroberts, please review this.

Codecov Report

Merging#519 intomaster willdecrease coverage by0.18%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #519      +/-   ##==========================================- Coverage   77.34%   77.16%   -0.19%==========================================  Files          65       65                Lines        5611     5610       -1       Branches      889      888       -1     ==========================================- Hits         4340     4329      -11- Misses        983      993      +10  Partials      288      288

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4b381bf...441dacf. Read thecomment docs.

Tested under windows, miniconda python 3.5, x64. All tests are passed.

@dmitriyse why do you have 2 similar pull requests?

This#518 PR contains only new build system which is able to build all current targets for windows and linux. And contains absolutely minimum changes in the code.

But this request contains NetStandard 2.0 build target + fixes in code to allow compile and pass tests.

Please see this comment#518 (comment), this PR should add new build target after#518 will be merged into the master.

@dmitriyse can you merge these 2 PR? I still don't understand why you separated them? And I still don't see any testing done for .NET Core target.

@dmitriyse can you merge these 2 PR? I still don't understand why you separated them? And I still don't see any testing done for .NET Core target.

@denfromufa
Please see this comment#518 (comment)

Debug session finished. I need to fix points received from this session.
All such imports:

[DllImport(_PythonDll,CallingConvention=CallingConvention.Cdecl)]internalstaticexternintPyDict_SetItemString(IntPtrpointer,stringkey,IntPtrvalue);

Should be modified to

[DllImport(_PythonDll,CallingConvention=CallingConvention.Cdecl,CharSet=CharSet.Ansi)]internalstaticexternintPyDict_SetItemString(IntPtrpointer,stringkey,IntPtrvalue);

And other build script fixes.

I managed to get EmbeddingTests works under NetCoreApp 2.0 target on all configurations except x86
x86 Support we can add later, once somebody will have enough time.

Both targets (net40 and netcoreapp2.0) are build and tested in the same --xplat CI configuration. It's simpler to implement and saves some time on awaiting build result.

Also I found a problem under NetCoreApp 2.0 - import "numpy" failed.

This PR is ready for merging to the master.
Current work allows to use python from the NetCoreApp 2.0 x64.

There are two main missing features, that can be implemented later:

1. x86 Support for .NetCoreApp 2.0
2. Access to .NetCoreApp 2.0 libraries from the genuine python.