NotificationsYou must be signed in to change notification settings
Fork752
Star5.1k

Fix the issue of sys.argv being cleared on import clr.#405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vmuriart merged 1 commit intopythonnet:masterfromfilmor:fix-sysargv-import

Feb 24, 2017

Merged

Fix the issue of sys.argv being cleared on import clr.#405

vmuriart merged 1 commit intopythonnet:masterfromfilmor:fix-sysargv-import

Feb 24, 2017

Conversation

Copy link

Member

filmor commentedFeb 24, 2017

Closes#404.

What does this implement/fix? Explain your changes.

Introduces asetSysArgv flag to allInitialize functions inPythonEngine, defaulting totrue and set tofalse forInitExt such thatimport clr doesn't callPySys_SetArgvEx.

Does this close any currently open issues?

#404.

Any other comments?

The test should already be in from another PR, from what I understood and since the change introducing this issue has not been released, yet, I don't think it need to go into the changelog.

Copy link

Contributor

vmuriart commentedFeb 24, 2017•
edited
Loading

@filmor just fixed the test for this onmaster if you want to check against it.
I ran the test againstv2.2.2 and our currentmaster to make sure it passed/xfailed respectively.

test against v2.2.2 -https://travis-ci.org/vmuriart/pythonnet/jobs/204904097

Fix the issue of sys.argv being cleared on import clr.

9e1a0e4

Closespythonnet#404.

vmuriart force-pushed thefix-sysargv-import branch frombac3ab3 to9e1a0e4Compare

February 24, 2017 18:11

Copy link

codecovbot commentedFeb 24, 2017

Codecov Report

Merging#405 intomaster willincrease coverage by0.02%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #405      +/-   ##==========================================+ Coverage   63.49%   63.51%   +0.02%==========================================  Files          60       60                Lines        5219     5222       +3       Branches      857      858       +1     ==========================================+ Hits         3314     3317       +3  Misses       1685     1685                Partials      220      220

Flag	Coverage Δ
#Embedded_Tests	`32.87% <100%> (+0.02%)`	✅
#Python_Tests	`60.45% <100%> (-0.18%)`	❌
#Setup_Linux	`74% <100%> (ø)`	✅
#Setup_Windows	`70.5% <100%> (ø)`	✅

Impacted Files	Coverage Δ
src/runtime/pythonengine.cs	`66.83% <100%> (+0.51%)`	✅

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update012b488...9e1a0e4. Read thecomment docs.

vmuriart merged commitfaf5faf intopythonnet:master

Feb 24, 2017

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix the issue of sys.argv being cleared on import clr.#405

Fix the issue of sys.argv being cleared on import clr.#405

Uh oh!