Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bumpversion#398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vmuriart merged 3 commits intopythonnet:masterfromvmuriart:bumpversion
Feb 22, 2017
Merged

Bumpversion#398

vmuriart merged 3 commits intopythonnet:masterfromvmuriart:bumpversion
Feb 22, 2017

Conversation

vmuriart
Copy link
Contributor

@vmuriartvmuriart commentedFeb 22, 2017
edited
Loading

What does this implement/fix? Explain your changes.

Automate version update.
Fixes conda-recipe version from lagging (used to look at last git-tag)
Fixes and centralizes AssemblyInfo version information

Does this close any currently open issues?

Closes#319

Any other comments?

Based from:peritus/bumpversion#77 (comment)

Example usage:

bumpversion patch:0.1.0 ->0.1.1.dev0
bumpversion release:0.1.1.dev0 ->0.1.1
bumpversion minor:0.1.1 ->0.2.0.dev0
bumpversion dev:0.2.0.dev0 ->0.2.0.dev1
bumpversion release:0.2.0.dev1 ->0.2.0

I chose to not add auto-commit/auto-tag. For one, its broken on PY3 and also would prefer testing out before potentially causing the git-history to get extremely messy.

Checklist

Check all those that are applicable and complete.

  • If an enhancement PR, please create docs and at best an example
  • Add yourself toAUTHORS

Get it from recipe file instead of git-tag.
Configuration based from gh:bumpversion:issues:77#issuecomment-130696156Usage:bumpversion major -> increases major and adds `dev` if not presentbumpversion minor -> increases minor and adds `dev` if not presentbumpversion release -> drop the `dev` portion
@vmuriart
Copy link
ContributorAuthor

conda-builds with correct version.

image

@den-run-ai
Copy link
Contributor

@vmuriart so why not versioneer which is also internally used by conda-build? bumpversion has stalled for 2 years and it is also used 10 times less on github:

https://github.com/search?l=Python&q=bumpversion&ref=searchresults&type=Code&utf8=%E2%9C%93
https://github.com/search?l=Python&q=versioneer&type=Code&utf8=%E2%9C%93

Is it easier to use or has some features?

@vmuriart
Copy link
ContributorAuthor

I forgot to add my reasoning, thanks for the reminder.

versioneer requires that the source code be checked-in with the repository and updated periodically for new updates.

theversion is calculated at runtime withimport versioneer; __version__ = versioneer.get_version() which works great on python script/files but not as well on static files or non-python language files (such as our use case).bumpversion on the other hand statically updates all the files. In the end this is what tipped the scales.

bumpversion has alot of quirks (which I documented for how annoying they were) but in the end was the simpler solution. I gaveversioneer multiple tries but in the end I couldn't integrate it for our use.

@den-run-ai
Copy link
Contributor

can you add instructions to developer docs?

https://github.com/pythonnet/pythonnet/wiki/Development-setup

@vmuriart
Copy link
ContributorAuthor

Added the documentation to thewiki.
Just reviewed the search results from above, I think they are a bit skewed sinceversioneer commits itself into each project that uses it and might show up in the results more because of it.

@vmuriartvmuriart merged commit909b7c0 intopythonnet:masterFeb 22, 2017
@vmuriartvmuriart deleted the bumpversion branchFebruary 22, 2017 06:43
@vmuriartvmuriart added this to the2.3.0 milestoneFeb 22, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@den-run-aiden-run-aiden-run-ai approved these changes

@filmorfilmorAwaiting requested review from filmor

@tonyrobertstonyrobertsAwaiting requested review from tonyroberts

Assignees

@vmuriartvmuriart

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Automate version update
2 participants
@vmuriart@den-run-ai

[8]ページ先頭

©2009-2025 Movatter.jp